Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording #40

Closed

Conversation

jbachorik
Copy link

@jbachorik jbachorik commented Dec 29, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/40/head:pull/40
$ git checkout pull/40

Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/40/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 40

View PR using the GUI difftool:
$ git pr show -t 40

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/40.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2021

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 475ec8e6c5abc3431344d69bd46395e8c4b46e4c 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording Dec 29, 2021
@openjdk
Copy link

openjdk bot commented Dec 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 29, 2021

@jbachorik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 29, 2021

Webrevs

@jbachorik
Copy link
Author

jbachorik commented Jan 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 6, 2022

Going to push as commit 4a188e9.
Since your change was applied there have been 16 commits pushed to the master branch:

  • ca59b64: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for
  • 9acabeb: 8278104: C1 should support the compiler directive 'BreakAtExecute'
  • 0ccdda4: 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures
  • 775e81d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • bd28050: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux
  • a471f7a: 8275800: Redefinition leaks MethodData::_extra_data_lock
  • ccb5f86: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java
  • 8e6ed88: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails
  • 7daca99: 8275326: C2: assert(no_dead_loop) failed: dead loop detected
  • 256356d: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
  • ... and 6 more: https://git.openjdk.java.net/jdk17u-dev/compare/f016e603af58010cd02d8f7275671444ae9a420b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2022
@openjdk openjdk bot closed this Jan 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2022
@openjdk
Copy link

openjdk bot commented Jan 6, 2022

@jbachorik Pushed as commit 4a188e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant