Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240903: Add test to check that jmod hashes are reproducible #423

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 29, 2022

Hi all,

This pull request contains a backport of JDK-8240903, commit 96952834 from the openjdk/jdk repository.

The commit being backported was authored by Dongbo He on 16 Apr 2022 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8240903: Add test to check that jmod hashes are reproducible

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/423/head:pull/423
$ git checkout pull/423

Update a local copy of the PR:
$ git checkout pull/423
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 423

View PR using the GUI difftool:
$ git pr show -t 423

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/423.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9695283458c273c2a4121f88a2a971ad4f297d5b 8240903: Add test to check that jmod hashes are reproducible May 29, 2022
@openjdk
Copy link

openjdk bot commented May 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 29, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8240903: Add test to check that jmod hashes are reproducible

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 18d3e4d: 8287336: GHA: Workflows break on patch versions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 29, 2022
@mlbridge
Copy link

mlbridge bot commented May 29, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jun 2, 2022

Hi,
what is wrong on windows?
Does the test pass?

@RealCLanger
Copy link
Contributor Author

Hi, what is wrong on windows? Does the test pass?

The windows issues will be fixed with openjdk/jdk17u#343
The test passes, I ran it locally and through SAP's nightly.

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 2, 2022

Going to push as commit 629754e.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 9a4a6ab: 8287202: GHA: Add macOS aarch64 to the list of default platforms for workflow_dispatch event
  • 6850786: 8287016: Bump update version for OpenJDK: jdk-17.0.5
  • 6b5186e: 8284661: Reproducible assembly builds without relative linking
  • 9439a87: 8284094: Memory leak in invoker_completeInvokeRequest()
  • 3e42e25: 8284437: Building from different users/workspace is not always deterministic
  • 4330e5f: 8287362: FieldAccessWatch testcase failed on AIX platform
  • b9841d4: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale
  • 18d3e4d: 8287336: GHA: Workflows break on patch versions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 2, 2022
@openjdk openjdk bot closed this Jun 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2022
@openjdk
Copy link

openjdk bot commented Jun 2, 2022

@RealCLanger Pushed as commit 629754e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants