Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281628: KeyAgreement : generateSecret intermittently not resetting #437

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 7, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281628: KeyAgreement : generateSecret intermittently not resetting

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/437/head:pull/437
$ git checkout pull/437

Update a local copy of the PR:
$ git checkout pull/437
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 437

View PR using the GUI difftool:
$ git pr show -t 437

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/437.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1485883c9e6e24315bb21f20604b1c326e862a5b 8281628: KeyAgreement : generateSecret intermittently not resetting Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281628: KeyAgreement : generateSecret intermittently not resetting

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 8, 2022

Pre-submit failure: windows tests known to be failing. Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Jun 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 8, 2022

Going to push as commit c2d2dc7.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 2903d59: 8282467: add extra diagnostics for JDK-8268184
  • 4b1bba8: Merge
  • 3472ab2: 8286855: javac error on invalid jar should only print filename
  • 6ed9725: 8287162: (zipfs) Performance regression related to support for POSIX file permissions
  • 18e0dfc: 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups
  • 4a19cdc: 8286444: javac errors after JDK-8251329 are not helpful enough to find root cause
  • e266ffd: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jun 8, 2022
@openjdk openjdk bot closed this Jun 8, 2022
@openjdk openjdk bot removed ready rfr labels Jun 8, 2022
@openjdk
Copy link

openjdk bot commented Jun 8, 2022

@GoeLin Pushed as commit c2d2dc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant