Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277195 missing CAccessibility definition in [CommonComponentAccessibility accessibilityHitTest] #275

Closed
wants to merge 1 commit into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Nov 17, 2021

A part of the fix JDK-8274381 has already been back ported to 17u, however after the fix JDK-8267385 the rest changes need to be back ported too.

It's this chunk:

  • (id)accessibilityHitTest:(NSPoint)point
    {
    JNIEnv* env = [ThreadUtilities getJNIEnv];
  • GET_CACCESSIBILITY_CLASS_RETURN(nil);

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277195: missing CAccessibility definition in [CommonComponentAccessibility accessibilityHitTest]

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/275/head:pull/275
$ git checkout pull/275

Update a local copy of the PR:
$ git checkout pull/275
$ git pull https://git.openjdk.java.net/jdk17u pull/275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 275

View PR using the GUI difftool:
$ git pr show -t 275

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/275.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2021

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2021
@savoptik
Copy link
Contributor Author

savoptik commented Nov 17, 2021

/reviewer credit @azuev-java @pankaj-bansal @forantar

@openjdk
Copy link

openjdk bot commented Nov 17, 2021

@savoptik
Reviewer kizune successfully credited.

Reviewer pbansal successfully credited.

Reviewer ant successfully credited.

@mlbridge
Copy link

mlbridge bot commented Nov 17, 2021

Webrevs

@savoptik savoptik changed the title 8277195 missing CAccessibility definition in [CommonComponentAccessib… 8277195 missing CAccessibility definition in [CommonComponentAccessibility accessibilityHitTest] Nov 17, 2021
@openjdk
Copy link

openjdk bot commented Nov 17, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277195: missing CAccessibility definition in [CommonComponentAccessibility accessibilityHitTest]

Reviewed-by: ant, kizune, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 03ef5a9: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 562cb4a: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • 716eeb0: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 01a9e63: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow
  • 2d69b2d: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • 6aa02d7: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • 38db452: 8272170: Missing memory barrier when checking active state for regions
  • acecce5: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
  • 19201da: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
  • ... and 13 more: https://git.openjdk.java.net/jdk17u/compare/f9eed140be80840531ddb40a5d28e2142eaab506...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@forantar, @azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2021
@savoptik
Copy link
Contributor Author

savoptik commented Nov 23, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@savoptik
Your change (at version 15c0bc9) is now ready to be sponsored by a Committer.

@forantar
Copy link
Contributor

forantar commented Nov 23, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

Going to push as commit 7ffac79.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 03ef5a9: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 562cb4a: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • 716eeb0: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 01a9e63: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow
  • 2d69b2d: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • 6aa02d7: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • 38db452: 8272170: Missing memory barrier when checking active state for regions
  • acecce5: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
  • 19201da: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
  • ... and 13 more: https://git.openjdk.java.net/jdk17u/compare/f9eed140be80840531ddb40a5d28e2142eaab506...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@forantar @savoptik Pushed as commit 7ffac79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@forantar The command reviewer can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants