Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups #140

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 28, 2022

Hi all,

This pull request contains a backport of JDK-8286594, commit 80cf9f34 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 14 May 2022 and was reviewed by Lance Andersen.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/140/head:pull/140
$ git checkout pull/140

Update a local copy of the PR:
$ git checkout pull/140
$ git pull https://git.openjdk.java.net/jdk18u pull/140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 140

View PR using the GUI difftool:
$ git pr show -t 140

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/140.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 80cf9f3464c599fb7860432bf4ed506a3b298d8e 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups May 28, 2022
@openjdk
Copy link

openjdk bot commented May 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 28, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2022
@mlbridge
Copy link

mlbridge bot commented May 28, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2022

Going to push as commit 3062b46.
Since your change was applied there have been 4 commits pushed to the master branch:

  • e2acd4f: 8286444: javac errors after JDK-8251329 are not helpful enough to find root cause
  • 87375b4: 8284094: Memory leak in invoker_completeInvokeRequest()
  • 0982707: 8287162: (zipfs) Performance regression related to support for POSIX file permissions
  • d554a32: 8240903: Add test to check that jmod hashes are reproducible

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2022
@openjdk openjdk bot closed this May 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2022
@openjdk
Copy link

openjdk bot commented May 31, 2022

@RealCLanger Pushed as commit 3062b46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant