Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8279225: [arm32] C1 longs comparison operation destroys argument registers #15

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Feb 1, 2022

Backport of JDK-8279225. Applies cleanly. Fix request is pending.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279225: [arm32] C1 longs comparison operation destroys argument registers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/15/head:pull/15
$ git checkout pull/15

Update a local copy of the PR:
$ git checkout pull/15
$ git pull https://git.openjdk.java.net/jdk18u pull/15/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15

View PR using the GUI difftool:
$ git pr show -t 15

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/15.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 299022dfacbcb49e3bc5beca8ff9b1fca1101493 8279225: [arm32] C1 longs comparison operation destroys argument registers Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279225: [arm32] C1 longs comparison operation destroys argument registers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2022

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

Going to push as commit 313932a.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 2b74a8d: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM
  • e32fb7f: 8280910: Update openjdk project in jcheck to "jdk-updates" for jdk18u
  • 74e1fdb: Merge
  • ef08e2c: 8280592: Small javadoc tweaks to foreign API

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2022
@openjdk openjdk bot closed this Feb 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@TobiHartmann Pushed as commit 313932a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant