8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

[dcubed-ojdk]

A trivial fix to slightly increase the default timeout so that java/lang/reflect/IllegalArgumentsTest.java
passes with slowdebug bits.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

Reviewers

• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/60/head:pull/60
$ git checkout pull/60

Update a local copy of the PR:
$ git checkout pull/60
$ git pull https://git.openjdk.org/jdk20 pull/60/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 60

View PR using the GUI difftool:
$ git pr show -t 60

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/60.diff

[dcubed-ojdk]

/label add hotspot-runtime
/label add core-libs

[bridgekeeper]

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dcubed-ojdk
The hotspot-runtime label was successfully added.

[openjdk]

@dcubed-ojdk
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 00: Full (88ed1ea7)

[openjdk]

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 3e17e3c: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

@irisclark - Thanks for the fast review. Do you agree that this is a trivial fix?
That would allow me to skip the 24 hour rule...

[irisclark]

Trivial update approved.

[dcubed-ojdk]

@irisclark - Thanks!

/integrate

[openjdk]

Going to push as commit f07acfc.
Since your change was applied there has been 1 commit pushed to the master branch:

• 3e17e3c: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus

Your commit was automatically rebased without conflicts.

[openjdk]

@dcubed-ojdk Pushed as commit f07acfc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Mailing list message from Iris Clark on core-libs-dev:

I agree that this is a trivial fix.

Iris

________________________________
From: core-libs-dev <core-libs-dev-retn at openjdk.org> on behalf of Daniel D.Daugherty <dcubed at openjdk.org>
Sent: Monday, December 19, 2022 2:46 PM
To: core-libs-dev at openjdk.org <core-libs-dev at openjdk.org>; hotspot-runtime-dev at openjdk.org <hotspot-runtime-dev at openjdk.org>
Subject: Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

On Mon, 19 Dec 2022 22:34:00 GMT, Iris Clark <iris at openjdk.org> wrote:

A trivial fix to slightly increase the default timeout so that java/lang/reflect/IllegalArgumentsTest.java
passes with slowdebug bits.

Marked as reviewed by iris (Reviewer).

@irisclark - Thanks for the fast review. Do you agree that this is a trivial fix?
That would allow me to skip the 24 hour rule...

-------------

PR: https://git.openjdk.org/jdk20/pull/60
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20221219/8d63e070/attachment.htm>