Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

JDK-8299235 broken link referencing missing id #77

Closed
wants to merge 1 commit into from

Conversation

mcpowers
Copy link

@mcpowers mcpowers commented Dec 23, 2022

https://bugs.openjdk.org/browse/JDK-8299235


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/77/head:pull/77
$ git checkout pull/77

Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.org/jdk20 pull/77/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 77

View PR using the GUI difftool:
$ git pr show -t 77

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/77.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2022

👋 Welcome back mpowers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2022
@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@mcpowers The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 23, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@mcpowers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299235: broken link referencing missing id

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • a6a903d: 8288204: GVN Crash: assert() failed: correct memory chain
  • 37f8b05: 8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics
  • 188911c: 8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file
  • 33042a4: 8299237: add ArraysSupport.newLength test to a test group
  • a80c91d: 8299230: Use https: in links
  • 9863f59: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes
  • 5e001d6: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
  • a0a09d5: 8298176: remove OpaqueZeroTripGuardPostLoop once main-loop disappears
  • fef70d7: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2023
@mcpowers
Copy link
Author

mcpowers commented Jan 3, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@mcpowers
Your change (at version c5bef1d) is now ready to be sponsored by a Committer.

@seanjmullan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

Going to push as commit 3eb85d1.
Since your change was applied there have been 9 commits pushed to the master branch:

  • a6a903d: 8288204: GVN Crash: assert() failed: correct memory chain
  • 37f8b05: 8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics
  • 188911c: 8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file
  • 33042a4: 8299237: add ArraysSupport.newLength test to a test group
  • a80c91d: 8299230: Use https: in links
  • 9863f59: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes
  • 5e001d6: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
  • a0a09d5: 8298176: remove OpaqueZeroTripGuardPostLoop once main-loop disappears
  • fef70d7: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2023
@openjdk openjdk bot closed this Jan 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@seanjmullan @mcpowers Pushed as commit 3eb85d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mcpowers mcpowers deleted the JDK-8299235 branch January 4, 2023 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants