Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java #54

Conversation

iklam
Copy link
Member

@iklam iklam commented Apr 8, 2023

Not a clean backport.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.org/jdk20u.git pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/54.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2023

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f45b01f8830a8d42a486374e8c3dadc845bfc59f 8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java Apr 8, 2023
@openjdk
Copy link

openjdk bot commented Apr 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 8, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2023

Webrevs

@iklam
Copy link
Member Author

iklam commented Apr 11, 2023

Thanks @plummercj for the review
/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2023

@iklam This pull request has not yet been marked as ready for integration.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented Apr 11, 2023

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java

Reviewed-by: cjplummer, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 8ef9ff3: 8296318: use-def assert: special case undetected loops nested in infinite loops
  • f00d946: 8298568: Fastdebug build fails after JDK-8296389
  • f703356: 8303069: Memory leak in CompilerOracle::parse_from_line

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 11, 2023
@iklam
Copy link
Member Author

iklam commented Apr 11, 2023

Thanks @plummercj and @dcubed-ojdk for the review
/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2023

Going to push as commit 56ad721.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 8ef9ff3: 8296318: use-def assert: special case undetected loops nested in infinite loops
  • f00d946: 8298568: Fastdebug build fails after JDK-8296389
  • f703356: 8303069: Memory leak in CompilerOracle::parse_from_line

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2023
@openjdk openjdk bot closed this Apr 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2023
@openjdk
Copy link

openjdk bot commented Apr 11, 2023

@iklam Pushed as commit 56ad721.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
3 participants