Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8307104: [AIX] VM crashes with UseRTMLocking on Power10 #77

Closed
wants to merge 1 commit into from

Conversation

backwaterred
Copy link

@backwaterred backwaterred commented May 11, 2023

Prevent crashes on platforms that don't support transnational memory instructions.

I encountered conflicts with the header file years while making this change. No conflicts with functionality. Essentially a clean backport, but I will wait for a review before proceeding.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307104: [AIX] VM crashes with UseRTMLocking on Power10

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/77/head:pull/77
$ git checkout pull/77

Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.org/jdk20u.git pull/77/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 77

View PR using the GUI difftool:
$ git pr show -t 77

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/77.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2023

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 860bf9b35fb168b7b725388c797f193564d9af4d 8307104: [AIX] VM crashes with UseRTMLocking on Power10 May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 11, 2023
@mlbridge
Copy link

mlbridge bot commented May 11, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright dates differences are considered clean. Lgtm.

@openjdk
Copy link

openjdk bot commented May 12, 2023

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307104: [AIX] VM crashes with UseRTMLocking on Power10

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 2302454: 8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls
  • 511ba72: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0
  • 8f816bb: 8307378: Allow collectors to provide specific values for GC notifications' actions
  • 47b3b4c: 8307466: java.time.Instant calculation bug in until and between methods

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 12, 2023
@backwaterred
Copy link
Author

The issue has received approval.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

@backwaterred
Your change (at version 005674f) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 19, 2023

Going to push as commit 68fb0aa.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 2302454: 8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls
  • 511ba72: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0
  • 8f816bb: 8307378: Allow collectors to provide specific values for GC notifications' actions
  • 47b3b4c: 8307466: java.time.Instant calculation bug in until and between methods

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 19, 2023
@openjdk openjdk bot closed this May 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

@phohensee @backwaterred Pushed as commit 68fb0aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants