Skip to content

Commit

Permalink
Restrict symbol version map to global symbols
Browse files Browse the repository at this point in the history
ld.lld-17 fails to link when symbols such as

    ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
    symbol '_ZTVZ21WB_HandshakeWalkStackE16TraceSelfClosure' failed:
    symbol not defined

    ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
    symbol '_ZTVZ24WB_HandshakeReadMonitorsE19ReadMonitorsClosure'
    failed: symbol not defined

    ld.lld: error: version script assignment of 'SUNWprivate_1.1' to
    symbol '_ZTVZ26WB_AsyncHandshakeWalkStackE16TraceSelfClosure'
    failed: symbol not defined

are listed in the version map. nm indicates these symbols are defined as
local symbols. Remove them from the version map to resolve the issues.
  • Loading branch information
nvinson committed Jan 13, 2024
1 parent cd16670 commit f480f53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion make/hotspot/lib/JvmMapfile.gmk
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ endif
# platform dependent.

ifeq ($(call isTargetOs, linux), true)
DUMP_SYMBOLS_CMD := $(NM) $(NMFLAGS) --defined-only *$(OBJ_SUFFIX)
DUMP_SYMBOLS_CMD := $(NM) $(NMFLAGS) --defined-only --extern-only *$(OBJ_SUFFIX)
ifneq ($(FILTER_SYMBOLS_PATTERN), )
FILTER_SYMBOLS_PATTERN := $(FILTER_SYMBOLS_PATTERN)|
endif
Expand Down

0 comments on commit f480f53

Please sign in to comment.