-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX #30
Conversation
👋 Welcome back jkern! A progress list of the required criteria for merging this PR into |
|
/approval JDK-8319633 request Backport of test fix for AIX. No risk, clean backport. |
@JoKern65 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken, @TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/Integrate |
/sponsor |
/integrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/sponsor |
Going to push as commit dcf6eea.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr @JoKern65 Pushed as commit dcf6eea. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Every 1-2 weeks we run into timeouts when running jtreg test runtime/posixSig/TestPosixSig.java on UNIX.
The thread stack shows that we are in line 54 of TestPosixSig.java (callstack see below).
The reason is the following: The test registers a new dummy signal handler for SIGILL, without delegating the task to the previous handler in the chain. In case the VM then calls a Java method marked as not-entrant at least on PPC64 a SIGILL is raised. Because this is not handled by the registered handler the SIGILL will happen again and again in an endless recursion.
One solution would be to run the test in interpreted mode.
Progress
Issue
Backport <hash>
with the hash of the original commit. See Backports.Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/30/head:pull/30
$ git checkout pull/30
Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/30/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30
View PR using the GUI difftool:
$ git pr show -t 30
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/30.diff
Webrev
Link to Webrev Comment