Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX #30

Closed
wants to merge 1 commit into from

Conversation

JoKern65
Copy link

@JoKern65 JoKern65 commented Dec 14, 2023

Every 1-2 weeks we run into timeouts when running jtreg test runtime/posixSig/TestPosixSig.java on UNIX.
The thread stack shows that we are in line 54 of TestPosixSig.java (callstack see below).

The reason is the following: The test registers a new dummy signal handler for SIGILL, without delegating the task to the previous handler in the chain. In case the VM then calls a Java method marked as not-entrant at least on PPC64 a SIGILL is raised. Because this is not handled by the registered handler the SIGILL will happen again and again in an endless recursion.
One solution would be to run the test in interpreted mode.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319633 needs maintainer approval

Issue

  • JDK-8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX (Bug - P4 - Approved) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/30.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2023

👋 Welcome back jkern! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

⚠️ @JoKern65 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@JoKern65
Copy link
Author

/approval JDK-8319633 request Backport of test fix for AIX. No risk, clean backport.

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@JoKern65
JDK-8319633: The approval request was already up to date.

@openjdk openjdk bot added the approval label Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@JoKern65 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX

Reviewed-by: mbaesken, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • fccb0a1: 8321131: Console read line with zero out should zero out underlying buffer in JLine
  • db343c9: 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector
  • 63aecc5: 8320300: Adjust hs_err output in malloc/mmap error cases
  • e8cf56c: 8320798: Console read line with zero out should zero out underlying buffer
  • d65289d: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
  • 901048b: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 0106db0: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken, @TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 15, 2023
@JoKern65
Copy link
Author

/Integrate

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@MBaesken The change author (@JoKern65) must issue an integrate command before the integration can be sponsored.

@JoKern65
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@JoKern65
Your change (at version 10658a9) is now ready to be sponsored by a Committer.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

Going to push as commit dcf6eea.
Since your change was applied there have been 7 commits pushed to the master branch:

  • fccb0a1: 8321131: Console read line with zero out should zero out underlying buffer in JLine
  • db343c9: 8314612: TestUnorderedReduction.java fails with -XX:MaxVectorSize=32 and -XX:+AlignVector
  • 63aecc5: 8320300: Adjust hs_err output in malloc/mmap error cases
  • e8cf56c: 8320798: Console read line with zero out should zero out underlying buffer
  • d65289d: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
  • 901048b: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 0106db0: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2023
@openjdk openjdk bot closed this Dec 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@TheRealMDoerr @JoKern65 Pushed as commit dcf6eea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants