Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows. #178

Closed
wants to merge 1 commit into from

Conversation

LudwikJaniuk
Copy link

@LudwikJaniuk LudwikJaniuk commented Sep 20, 2023

.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316199 needs maintainer approval

Issue

  • JDK-8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows. (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/178/head:pull/178
$ git checkout pull/178

Update a local copy of the PR:
$ git checkout pull/178
$ git pull https://git.openjdk.org/jdk21u.git pull/178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 178

View PR using the GUI difftool:
$ git pr show -t 178

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/178.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2023

👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 903b9e8dd966fbb61222c59048b752ed8b42b608 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows. Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 20, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2023

Webrevs

Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

⚠️ @LudwikJaniuk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Sep 20, 2023
@LudwikJaniuk
Copy link
Author

/integrate auto

@openjdk openjdk bot added the auto label Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@LudwikJaniuk This pull request will be automatically integrated when it is ready

@kevinjwalls
Copy link
Contributor

Hi Ludvig - if this is going into jdk21, it's probably best to backport https://bugs.openjdk.org/browse/JDK-8314476 as well. It's another test tweak, and not the reason this was in the problemlist, but it should help with making the test retry when ports are scarce.

@LudwikJaniuk
Copy link
Author

/integrate manual

@openjdk openjdk bot removed the auto label Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@LudwikJaniuk This pull request will have to be integrated manually using the /integrate pull request command.

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@LudwikJaniuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.

Reviewed-by: coffeys, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 768592a: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"
  • 86a1a44: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns
  • c6ff3f7: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 3b58919: 8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children
  • 9983caa: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • 4eafc45: 8313322: RISC-V: implement MD5 intrinsic
  • 305be8f: 8314045: ArithmeticException in GaloisCounterMode
  • 487a726: 8316178: Better diagnostic header for CodeBlobs
  • 3b690f1: 8308592: Framework for CA interoperability testing
  • e2bfc22: 8315578: PPC builds are broken after JDK-8304913
  • ... and 11 more: https://git.openjdk.org/jdk21u/compare/acd23acf8029a02f44d9a6aff88b72ee9a220be6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @kevinjwalls) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 21, 2023
@LudwikJaniuk
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@LudwikJaniuk
Your change (at version 364435c) is now ready to be sponsored by a Committer.

@kevinjwalls
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

Going to push as commit ccf8451.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 768592a: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"
  • 86a1a44: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns
  • c6ff3f7: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 3b58919: 8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children
  • 9983caa: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • 4eafc45: 8313322: RISC-V: implement MD5 intrinsic
  • 305be8f: 8314045: ArithmeticException in GaloisCounterMode
  • 487a726: 8316178: Better diagnostic header for CodeBlobs
  • 3b690f1: 8308592: Framework for CA interoperability testing
  • e2bfc22: 8315578: PPC builds are broken after JDK-8304913
  • ... and 11 more: https://git.openjdk.org/jdk21u/compare/acd23acf8029a02f44d9a6aff88b72ee9a220be6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2023
@openjdk openjdk bot closed this Sep 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2023
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@kevinjwalls @LudwikJaniuk Pushed as commit ccf8451.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants