8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows

[manukumarvs]

This is a problem listing changeset created by Lawrence on mainline and he wanted it to be backported to jdk21u. This includes the backport of the related fix JDK-8317964 also, that's why it is not marked as clean.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317964 needs maintainer approval
• JDK-8317751 needs maintainer approval

Issues

• JDK-8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows (Bug - P4 - Approved)
• JDK-8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751 (Bug - P2 - Approved)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Committer)
• Dmitry Markov (@dmarkov20 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/280/head:pull/280
$ git checkout pull/280

Update a local copy of the PR:
$ git checkout pull/280
$ git pull https://git.openjdk.org/jdk21u.git pull/280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 280

View PR using the GUI difftool:
$ git pr show -t 280

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/280.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @manukumarvs This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[manukumarvs]

/approval JDK-8317751 request Backporting the problem listing bug to jdk21u

[manukumarvs]

/integrate auto

[openjdk]

@manukumarvs
JDK-8317751: The approval request has been created successfully.

[openjdk]

@manukumarvs This pull request will be automatically integrated when it is ready

[mlbridge]

Webrevs

• 01: Full - Incremental (eefd8727)
• 00: Full (a4c91140)

[manukumarvs]

/issue 8317964

[openjdk]

@manukumarvs
Adding additional issue to issue list: 8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751.

[manukumarvs]

/approval JDK-8317964 request Backporting this fix is required because of a regression created by JDK-8317751

[openjdk]

@manukumarvs
JDK-8317964: The approval request has been created successfully.

[manukumarvs]

I have build and tested it using mach5 and the links are attached to the bugs.

[aivanov-jdk]

Looks good to me.

[dmarkov20]

Looks fine

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows
8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751

Reviewed-by: aivanov, dmarkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 5dd22a9: 8317959: Check return values of malloc in native java.base coding
• e3a2eeb: 8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl()
• bcd73c5: 8310512: Cleanup indentation in jfc files
• b7e0c4a: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
• eb6ea91: 8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge
• 00698a4: 8317373: Add Telia Root CA v2
• 0fc04fb: 8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes
• 2bf263d: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
• 9f0d9ca: 8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize
• 294c19d: 8315088: C2: assert(wq.size() - before == EMPTY_LOOP_SIZE) failed: expect the EMPTY_LOOP_SIZE nodes of this body if empty
• ... and 1 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @dmarkov20) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

/integrate

[openjdk]

@openjdk[bot]
Your change (at version eefd872) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit 5ebc02b.
Since your change was applied there have been 11 commits pushed to the master branch:

• 5dd22a9: 8317959: Check return values of malloc in native java.base coding
• e3a2eeb: 8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl()
• bcd73c5: 8310512: Cleanup indentation in jfc files
• b7e0c4a: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
• eb6ea91: 8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge
• 00698a4: 8317373: Add Telia Root CA v2
• 0fc04fb: 8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes
• 2bf263d: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
• 9f0d9ca: 8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize
• 294c19d: 8315088: C2: assert(wq.size() - before == EMPTY_LOOP_SIZE) failed: expect the EMPTY_LOOP_SIZE nodes of this body if empty
• ... and 1 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @manukumarvs Pushed as commit 5ebc02b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.