-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem #48
Conversation
👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@kumarabhi006 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@savoptik, @azuev-java) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@azuev-java and @savoptik Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/integrate |
@kumarabhi006 |
/sponsor |
Going to push as commit f7626de.
Your commit was automatically rebased without conflicts. |
@jayathirthrao @kumarabhi006 Pushed as commit f7626de. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is backport of https://bugs.openjdk.org/browse/JDK-8311160 to jdk21u.
VoiceOver doesn't announce anything for JRadioButtonMenuItem and JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem and JCheckBoxMenuItem are having an accessible role of RadioButton and CheckBox respectively and it is required to notify native side whenever they are selected.
Added the required fix and tested with SwingSet2 application. CI testing is also fine.
Fix can be tested with SwingSet2 application and test instructions are mentioned in JDK-8311160 description.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/48/head:pull/48
$ git checkout pull/48
Update a local copy of the PR:
$ git checkout pull/48
$ git pull https://git.openjdk.org/jdk21u.git pull/48/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 48
View PR using the GUI difftool:
$ git pr show -t 48
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/48.diff
Webrev
Link to Webrev Comment