Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem #48

Closed
wants to merge 1 commit into from

Conversation

kumarabhi006
Copy link

@kumarabhi006 kumarabhi006 commented Aug 9, 2023

This is backport of https://bugs.openjdk.org/browse/JDK-8311160 to jdk21u.

VoiceOver doesn't announce anything for JRadioButtonMenuItem and JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem and JCheckBoxMenuItem are having an accessible role of RadioButton and CheckBox respectively and it is required to notify native side whenever they are selected.

Added the required fix and tested with SwingSet2 application. CI testing is also fine.

Fix can be tested with SwingSet2 application and test instructions are mentioned in JDK-8311160 description.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/48/head:pull/48
$ git checkout pull/48

Update a local copy of the PR:
$ git checkout pull/48
$ git pull https://git.openjdk.org/jdk21u.git pull/48/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 48

View PR using the GUI difftool:
$ git pr show -t 48

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/48.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2023

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c1f4595e64b0ea0439c6e7f61a6a92b56b526d97 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem Aug 9, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem

Reviewed-by: asemenov, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 956d563: 8311511: Improve description of NativeLibrary JFR event
  • afd6c7a: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
  • 56e6e45: 8314118: Update JMH devkit to 1.37
  • 8912d3e: 8312127: FileDescriptor.sync should temporarily increase parallelism
  • b06ee41: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased
  • bd634d2: 8313307: java/util/Formatter/Padding.java fails on some Locales
  • bdf9f4b: 8308474: DSA does not reset SecureRandom when initSign is called again
  • f67c241: 8313248: C2: setScopedValueCache intrinsic exposes nullptr pre-values to store barriers
  • fc624df: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction
  • a094e93: 8293114: JVM should trim the native heap
  • ... and 4 more: https://git.openjdk.org/jdk21u/compare/51d128dafd6e51eb591dd9dbc4517b4e527b65b6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@savoptik, @azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2023

Webrevs

@kumarabhi006
Copy link
Author

@azuev-java and @savoptik Please review.

Copy link
Contributor

@savoptik savoptik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarabhi006
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@kumarabhi006
Your change (at version c59aec1) is now ready to be sponsored by a Committer.

@jayathirthrao
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

Going to push as commit f7626de.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 956d563: 8311511: Improve description of NativeLibrary JFR event
  • afd6c7a: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
  • 56e6e45: 8314118: Update JMH devkit to 1.37
  • 8912d3e: 8312127: FileDescriptor.sync should temporarily increase parallelism
  • b06ee41: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased
  • bd634d2: 8313307: java/util/Formatter/Padding.java fails on some Locales
  • bdf9f4b: 8308474: DSA does not reset SecureRandom when initSign is called again
  • f67c241: 8313248: C2: setScopedValueCache intrinsic exposes nullptr pre-values to store barriers
  • fc624df: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction
  • a094e93: 8293114: JVM should trim the native heap
  • ... and 4 more: https://git.openjdk.org/jdk21u/compare/51d128dafd6e51eb591dd9dbc4517b4e527b65b6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2023
@openjdk openjdk bot closed this Aug 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@jayathirthrao @kumarabhi006 Pushed as commit f7626de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
4 participants