8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468

[shipilev]

Clean backport to fix JDK 21 regression.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468 (Bug - P2)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/94/head:pull/94
$ git checkout pull/94

Update a local copy of the PR:
$ git checkout pull/94
$ git pull https://git.openjdk.org/jdk22.git pull/94/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 94

View PR using the GUI difftool:
$ git pr show -t 94

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/94.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6ea2433f)

[coleenp]

Thank you!

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks! Checking the rules for JDK 22, this is enough to integrate already, right?

[coleenp]

Yes, you can integrate.

[shipilev]

/integrate

[openjdk]

Going to push as commit 23301d5.

[openjdk]

@shipilev Pushed as commit 23301d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[kevinrushforth]

@shipilev During Rampdown Phase 2 (RDP2), approval to fix P1 and P2 bugs is needed by an Area lead or Group Lead as described in JEP 3, except for test and doc bugs can be fixed without requesting approval.

Since this has been integrated, I suggest that you request this approval after the fact.

[shipilev]

@shipilev During Rampdown Phase 2 (RDP2), approval to fix P1 and P2 bugs is needed by an Area lead or Group Lead as described in JEP 3, except for test and doc bugs can be fixed without requesting approval.

Since this has been integrated, I suggest that you request this approval after the fact.

Whoops. I wish bots knew jdk22 is a backport tree that requires jdk22-fix-yes to integrate!

Filed the request retroactively.

[kevinrushforth]

Whoops. I wish bots knew jdk22 is a backport tree that requires jdk22-fix-yes to integrate!

That would be challenging, since test bugs (noreg-self) and doc bugs (noreg-doc) are still OK, and the rules change at RDP2 and again at RC.