Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468 #94

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 22, 2024

Clean backport to fix JDK 21 regression.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/94/head:pull/94
$ git checkout pull/94

Update a local copy of the PR:
$ git checkout pull/94
$ git pull https://git.openjdk.org/jdk22.git pull/94/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 94

View PR using the GUI difftool:
$ git pr show -t 94

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/94.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bde650f21e2fa2f7730d3f948105159762e4fdd0 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468 Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 22, 2024

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 22, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2024

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@openjdk
Copy link

openjdk bot commented Jan 22, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 22, 2024
@shipilev
Copy link
Member Author

Thanks! Checking the rules for JDK 22, this is enough to integrate already, right?

@coleenp
Copy link
Contributor

coleenp commented Jan 22, 2024

Yes, you can integrate.

@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 22, 2024

Going to push as commit 23301d5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 22, 2024
@openjdk openjdk bot closed this Jan 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 22, 2024

@shipilev Pushed as commit 23301d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth
Copy link
Member

@shipilev During Rampdown Phase 2 (RDP2), approval to fix P1 and P2 bugs is needed by an Area lead or Group Lead as described in JEP 3, except for test and doc bugs can be fixed without requesting approval.

Since this has been integrated, I suggest that you request this approval after the fact.

@shipilev
Copy link
Member Author

@shipilev During Rampdown Phase 2 (RDP2), approval to fix P1 and P2 bugs is needed by an Area lead or Group Lead as described in JEP 3, except for test and doc bugs can be fixed without requesting approval.

Since this has been integrated, I suggest that you request this approval after the fact.

Whoops. I wish bots knew jdk22 is a backport tree that requires jdk22-fix-yes to integrate!

Filed the request retroactively.

@kevinrushforth
Copy link
Member

Whoops. I wish bots knew jdk22 is a backport tree that requires jdk22-fix-yes to integrate!

That would be challenging, since test bugs (noreg-self) and doc bugs (noreg-doc) are still OK, and the rules change at RDP2 and again at RC.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants