Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file #15

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Jul 5, 2024

Clean backport to fix a typo (an errant 's') in test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/functions/rawmonitor/rawmonitor.cpp introduced by JDK-8299635

This was spotted by George Adams (@gdams) when backporting 8299635 to 17u, where it is now needed to support builds on newer versions of Mac OS. It's a trivial fix it makes sense to clean up everywhere.

This pull request contains a backport of commit ff49f677 from the openjdk/jdk repository.

The commit being backported was authored by Severin Gehwolf on 5 Jul 2024 and was reviewed by George Adams and Thomas Stuefe.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335775 needs maintainer approval

Issue

  • JDK-8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/15/head:pull/15
$ git checkout pull/15

Update a local copy of the PR:
$ git checkout pull/15
$ git pull https://git.openjdk.org/jdk23u.git pull/15/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15

View PR using the GUI difftool:
$ git pr show -t 15

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/15.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bbbfb7f: 8334653: ISO 4217 Amendment 177 Update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ff49f677ee5017019c90823bc412ceb90068ffbd 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2024
@gnu-andrew
Copy link
Member Author

/approval request Trivial typo fix in a test that was spotted in backporting 8299635 to 17u. Makes sense to fix it everywhere.

@mlbridge
Copy link

mlbridge bot commented Jul 5, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@gnu-andrew
8335775: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 5, 2024
@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2024

Going to push as commit 5cfaec2.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 13e53b8: Merge
  • 5b9ecb1: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.
  • 70ad622: 8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed with CPU time out of expected range
  • ca37a48: 8334757: AssertionError: Missing type variable in where clause
  • ae10055: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
  • 4e52320: 8334433: jshell.exe runs an executable test.exe on startup
  • 2f60d36: 8335475: ClassBuilder incorrectly calculates max_locals in some cases
  • b415b98: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
  • 90d5b5b: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
  • 653c481: 8335479: JFR: Missing documentation for -XX:StartFlightRecording
  • ... and 9 more: https://git.openjdk.org/jdk23u/compare/2723ffa8ed19c70881d86a9f0cf188bc6d886a8c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2024
@openjdk openjdk bot closed this Jul 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2024
@openjdk
Copy link

openjdk bot commented Jul 11, 2024

@gnu-andrew Pushed as commit 5cfaec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant