-
Notifications
You must be signed in to change notification settings - Fork 25
8289907: Add missed jdk/src/share part of 8087283 #7
Conversation
👋 Welcome back yan! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
In general, OpenJDK projects require a new bug for this kind of thing, but the jdk7u project is of course free to define their own rules. I believe Skara will just add another commit message to the same bug if you choose to go through with this. |
Two bugs with the same bugid but different content and hashes are apparently a result of the forest consolidation: 8087283 has changed two different parts of the forest. I should perhaps combine both fixes in the previous commit but missed that one at the moment. I hope this crude approach would work. |
@yan-too This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hope to see it integrated for October release. |
@yan-too This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2af5704.
Your commit was automatically rebased without conflicts. |
It is a missed part of 8087283 cleanup fix. It has in head the same bug id and synopsis: I hope Skara jcheck would process it.
... UPDATE: bugid changed to a new 8289907 to keep it more conventional
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk7u pull/7/head:pull/7
$ git checkout pull/7
Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.org/jdk7u pull/7/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7
View PR using the GUI difftool:
$ git pr show -t 7
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk7u/pull/7.diff