Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8076190: Customizing the generation of a PKCS12 keystore #12

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Mar 17, 2022

Please find the backport of JDK-8076190 to JDK8u

This patch is already reviewed and approved on the JDK8u mailing list:

This PR is submitted to integrate already reviewed patch into the new git repository


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8076190: Customizing the generation of a PKCS12 keystore
  • JDK-8202590: Customizing the generation of a PKCS12 keystore (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/12.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2022

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9136c7d1d0e1247ea1ac95a6577acbb789169031 8076190: Customizing the generation of a PKCS12 keystore Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Mar 17, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2022

Webrevs

Copy link
Contributor

@martinuy martinuy left a comment

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8076190: Customizing the generation of a PKCS12 keystore

Reviewed-by: mbalao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 17, 2022
@alexeybakhtin
Copy link
Contributor Author

alexeybakhtin commented Mar 17, 2022

Already reviewed: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-February/014558.html

Thank you @martinuy for review it one more time

@alexeybakhtin
Copy link
Contributor Author

alexeybakhtin commented Mar 17, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

Going to push as commit 94cb2ef.

@openjdk openjdk bot added the integrated label Mar 17, 2022
@openjdk openjdk bot closed this Mar 17, 2022
@openjdk openjdk bot removed ready rfr labels Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@alexeybakhtin Pushed as commit 94cb2ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants