Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only #140

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Oct 16, 2022

Parity with Oracle. Clean backport. Also submitting a PR for https://bugs.openjdk.org/browse/JDK-8129827.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/140/head:pull/140
$ git checkout pull/140

Update a local copy of the PR:
$ git checkout pull/140
$ git pull https://git.openjdk.org/jdk8u-dev pull/140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 140

View PR using the GUI difftool:
$ git pr show -t 140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/140.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e52bc6a831807006a20720f849e975428353cd17 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only Oct 16, 2022
@openjdk
Copy link

openjdk bot commented Oct 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 16, 2022

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • b98d485: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp
  • 7ae002c: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled
  • 6849667: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer
  • 7024bf0: 8296959: Fix hotspot shell tests of 8u on multilib systems
  • 17fd40a: 8295714: GHA ::set-output is deprecated and will be removed
  • 2f509c7: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • f6d869f: 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64
  • 3bfde7d: 8284622: Update versions of some Github Actions used in JDK workflow
  • 3a1a2e0: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
  • 736c1fb: 8295288: Some vm_flags tests associate with a wrong BugID
  • ... and 27 more: https://git.openjdk.org/jdk8u-dev/compare/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2022

Webrevs

@caojoshua
Copy link
Contributor Author

Added #141 as follow up PR.

Windows failure does not look related to this change.

@phohensee
Copy link
Member

Tagged JBS issue.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2022

@caojoshua This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@caojoshua
Your change (at version 00b7ef3) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

Going to push as commit 9cb8752.
Since your change was applied there have been 37 commits pushed to the master branch:

  • b98d485: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp
  • 7ae002c: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled
  • 6849667: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer
  • 7024bf0: 8296959: Fix hotspot shell tests of 8u on multilib systems
  • 17fd40a: 8295714: GHA ::set-output is deprecated and will be removed
  • 2f509c7: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • f6d869f: 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64
  • 3bfde7d: 8284622: Update versions of some Github Actions used in JDK workflow
  • 3a1a2e0: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
  • 736c1fb: 8295288: Some vm_flags tests associate with a wrong BugID
  • ... and 27 more: https://git.openjdk.org/jdk8u-dev/compare/43cfe27fa3a11dd6d4fffcb1c1336ac7fdd0233b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2022
@openjdk openjdk bot closed this Nov 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@phohensee @caojoshua Pushed as commit 9cb8752.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants