8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails

[jerboaa]

Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/34/head:pull/34
$ git checkout pull/34

Update a local copy of the PR:
$ git checkout pull/34
$ git pull https://git.openjdk.org/jdk8u pull/34/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 34

View PR using the GUI difftool:
$ git pr show -t 34

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/34.diff

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (601e7658)

[phohensee]

Lgtm.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Thanks, Paul!

[gnu-andrew]

Backport looks good (though not clean as it doesn't include changes to ProblemList.txt, due to the absence of JDK-8263069)

I wouldn't usually approve this for a critical request on its own, but will do so as it's a pre-requisite for JDK-8245654

Do you know if we also need JDK-8263059, which fixes the third test excluded by 8263069?

[gnu-andrew]

Do you know if we also need JDK-8263059, which fixes the third test excluded by 8263069?

It seems we do, so I'll open a regular 8u-dev PR for that one.

[jerboaa]

Thanks!

/integrate

[openjdk]

Going to push as commit 7c0d5b4.

[openjdk]

@jerboaa Pushed as commit 7c0d5b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jerboaa]

Do you know if we also need JDK-8263059, which fixes the third test excluded by 8263069?

ComodoCA.java passes for me with latest jdk8u master:

Passed: sun/security/lib/cacerts/VerifyCACerts.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/CertignaCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/DTrustCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/EntrustCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/GoDaddyCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/LuxTrustCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/SSLCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/TeliaSoneraCA.java
Test results: passed: 15

[gnu-andrew]

Do you know if we also need JDK-8263059, which fixes the third test excluded by 8263069?

ComodoCA.java passes for me with latest jdk8u master:

Passed: sun/security/lib/cacerts/VerifyCACerts.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/CertignaCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/DTrustCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/EntrustCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/GoDaddyCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/LuxTrustCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/SSLCA.java
Passed: security/infra/java/security/cert/CertPathValidator/certification/TeliaSoneraCA.java
Test results: passed: 15

Passes with as well. Strange. openjdk/jdk8u-dev#276 will at least sync the test with 11u.

[gnu-andrew]

BTW, is there a reason these aren't in the GitHub Actions testing? It seems we could have caught these earlier if so and keeping this up-to-date seems important.

[jerboaa]

BTW, is there a reason these aren't in the GitHub Actions testing? It seems we could have caught these earlier if so and keeping this up-to-date seems important.

I don't think there is. Feel free to propose a patch to rectify this! Thanks.