-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails #34
Conversation
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks, Paul! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good (though not clean as it doesn't include changes to ProblemList.txt
, due to the absence of JDK-8263069)
I wouldn't usually approve this for a critical request on its own, but will do so as it's a pre-requisite for JDK-8245654
Do you know if we also need JDK-8263059, which fixes the third test excluded by 8263069?
It seems we do, so I'll open a regular 8u-dev PR for that one. |
Thanks! /integrate |
Going to push as commit 7c0d5b4. |
|
Passes with as well. Strange. openjdk/jdk8u-dev#276 will at least sync the test with 11u. |
BTW, is there a reason these aren't in the GitHub Actions testing? It seems we could have caught these earlier if so and keeping this up-to-date seems important. |
I don't think there is. Feel free to propose a patch to rectify this! Thanks. |
Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/34/head:pull/34
$ git checkout pull/34
Update a local copy of the PR:
$ git checkout pull/34
$ git pull https://git.openjdk.org/jdk8u pull/34/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 34
View PR using the GUI difftool:
$ git pr show -t 34
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/34.diff