8251353: Many javafx scenegraph classes have implicit no-arg construc…

…tors

Reviewed-by: kcr, nlisker

modules/javafx.controls/src/main/java/javafx/scene/control/TableFocusModel.java

@@ -42,6 +42,12 @@ public abstract class TableFocusModel<T, TC extends TableColumnBase<T,?>> extend
      *                                                                     *
      **********************************************************************/
 
+    /**
+     * Constructor for subclasses to call.
+     */
+    public TableFocusModel() {
+    }
+
     /**
      * Causes the item at the given index to receive the focus.
      *

modules/javafx.controls/src/main/java/javafx/scene/control/TableSelectionModel.java

@@ -37,6 +37,12 @@
  */
 public abstract class TableSelectionModel<T> extends MultipleSelectionModelBase<T> {
 
+    /**
+     * Constructor for subclasses to call.
+     */
+    public TableSelectionModel() {
+    }
+
     /**
      * Convenience function which tests whether the given row and column index
      * is currently selected in this table instance. If the table control is in its

modules/javafx.graphics/src/main/java/javafx/application/Preloader.java

@@ -114,6 +114,12 @@ public abstract class Preloader extends Application {
         lineSeparator = prop != null ? prop : "\n";
     }
 
+    /**
+     * Constructor for subclasses to call.
+     */
+    public Preloader() {
+    }
+
     /**
      * Indicates download progress.
      * This method is called by the FX runtime to indicate progress while

modules/javafx.graphics/src/main/java/javafx/concurrent/ScheduledService.java

@@ -144,6 +144,13 @@
  * @since JavaFX 8.0
  */
 public abstract class ScheduledService<V> extends Service<V> {
+
+    /**
+     * Constructor for subclasses to call.
+     */
+    public ScheduledService() {
+    }
+
     /**
      * A Callback implementation for the <code>backoffStrategy</code> property which
      * will exponentially backoff the period between re-executions in the case of

modules/javafx.graphics/src/main/java/javafx/css/PseudoClass.java

@@ -74,6 +74,12 @@
  */
 public abstract class PseudoClass {
 
+    /**
+     * Constructor for subclasses to call.
+     */
+    public PseudoClass() {
+    }
+
     /**
      * There is only one PseudoClass instance for a given pseudoClass.
      * @param pseudoClass the pseudo-class

modules/javafx.graphics/src/main/java/javafx/css/StyleConverter.java

@@ -86,6 +86,12 @@
  */
 public class StyleConverter<F, T> {
 
+    /**
+     * Creates a {@code StyleConverter}.
+     */
+    public StyleConverter() {
+    }
+
     /**
      * Convert from the parsed CSS value to the target property type.
      *
@@ -532,6 +538,12 @@ public static class StringStore {
         private final Map<String,Integer> stringMap = new HashMap<String,Integer>();
         public final List<String> strings = new ArrayList<String>();
 
+        /**
+         * Creates a {@code StringStore}.
+         */
+        public StringStore() {
+        }
+
         public int addString(String s) {
             Integer index = stringMap.get(s);
             if (index == null) {

modules/javafx.graphics/src/main/java/javafx/scene/input/ClipboardContent.java

@@ -38,6 +38,13 @@
  * @since JavaFX 2.0
  */
 public class ClipboardContent extends HashMap<DataFormat, Object> {
+
+    /**
+     * Creates a {@code ClipboardContent}.
+     */
+    public ClipboardContent() {
+    }
+
     /**
      * Gets whether a plain text String ({@code DataFormat.PLAIN_TEXT})
      * has been put to this {@code ClipboardContent}.

modules/javafx.graphics/src/main/java/javafx/scene/shape/PathElement.java

@@ -71,6 +71,12 @@ public void setHelper(PathElement pathElement, PathElementHelper pathElementHelp
      */
     WeakReferenceQueue nodes = new WeakReferenceQueue();
 
+    /**
+     * Constructor for subclasses to call.
+     */
+    public PathElement() {
+    }
+
     void addNode(final Node n) {
         nodes.add(n);
     }

modules/javafx.graphics/src/main/java/javafx/scene/transform/Transform.java

@@ -127,6 +127,12 @@ public Transform createImmutableTransform(Transform transform,
         });
     }
 
+    /**
+     * Constructor for subclasses to call.
+     */
+    public Transform() {
+    }
+
     /* *************************************************************************
      *                                                                         *
      *                            Factories                                    *

modules/javafx.graphics/src/main/java/javafx/stage/DirectoryChooser.java

@@ -49,6 +49,12 @@ public final class DirectoryChooser {
      */
     private StringProperty title;
 
+    /**
+     * Creates a {@code DirectoryChooser}.
+     */
+    public DirectoryChooser() {
+    }
+
     public final void setTitle(final String value) {
         titleProperty().set(value);
     }

modules/javafx.graphics/src/main/java/javafx/stage/FileChooser.java

@@ -204,6 +204,12 @@ private static void validateArgs(final String description,
      */
     private StringProperty title;
 
+    /**
+     * Creates a {@code FileChooser}.
+     */
+    public FileChooser() {
+    }
+
     public final void setTitle(final String value) {
         titleProperty().set(value);
     }

modules/javafx.graphics/src/main/java/javafx/stage/Popup.java

@@ -38,6 +38,12 @@
  */
 public class Popup extends PopupWindow {
 
+    /**
+     * Creates a {@code Popup}.
+     */
+    public Popup() {
+    }
+
     /**
      * The ObservableList of {@code Node}s to be rendered on this
      * {@code Popup}. The content forms the complete visual representation of