8308308: Update to Visual Studio 2022 version 17.5.0 on Windows #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
/contributor add hmeda |
|
/reviewers 2 |
|
@kevinrushforth |
|
@kevinrushforth |
|
@kevinrushforth |
arapte
approved these changes
May 24, 2023
|
When building this, I no longer get the compile error that is mentioned in the JBS issue, but instead I get this error: I am using compiler version |
|
We're also using compiler version Are you using python3 or still python2? We have seen some problems with python2 not working correctly with the latest WebKit update, although that error doesn't suggest a problem there. @HimaBinduMeda Any other ideas? |
|
Btw, here is the output of cmake from our CI build listing the other tools that the WebKit build is using (you can look for the ones you use by searching for "cmake" in your log file at the start of the |
|
I still get the same error when building with Windows SDK version For reference, I'll paste the full error message below: |
|
@tiainen Could you please try with python3.8.8 and share your observations? |
I would be very surprised if a micro version difference in python caused any problems, but if it's easy, it might be worth trying. One other possibility occurred to me. Are you using the Community edition of Visual Studio? Our devkit is based on (I think) the Professional edition (it might be the Enterprise edition...I'm checking into that). |
|
@tiainen After merging in the latest upstream master into this PR branch, I did another full CI build. No problems on our end. I presume you double-checked that you were building this PR branch earlier? If so, then we need to figure out what is different between your environment and ours. |
tiainen
approved these changes
Jun 1, 2023
arapte
approved these changes
Jun 1, 2023
|
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 8fc1a25.
Your commit was automatically rebased without conflicts. |
|
@kevinrushforth Pushed as commit 8fc1a25. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides the needed C++20 support for the next WebKit update.
On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 17.5.0 -- see JDK-8303748. The solution for the failure is to compile 615.1 using the C++20 flag for Windows (we will use this flag on all platforms for the next WebKit update). The fix for that bug is necessarily included in this PR, since the two fixes as interdependent.
/issue add 8303748
Progress
Issues
Reviewers
Contributors
<hmeda@openjdk.org>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1142/head:pull/1142$ git checkout pull/1142Update a local copy of the PR:
$ git checkout pull/1142$ git pull https://git.openjdk.org/jfx.git pull/1142/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1142View PR using the GUI difftool:
$ git pr show -t 1142Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1142.diff
Webrev
Link to Webrev Comment