8089134: [2D traversal, RTL] TraversalEngine only handles left/right key traversal correctly in RTL for top-level engine in ToolBar

[aghaisas]

Issue
https://bugs.openjdk.java.net/browse/JDK-8089134

Fix
Added a fix to modify selection direction based on NodeOrientation of the ToolBar.

Testing
Added a unit test to test common focus movement scenarios using tab and arrow keys for the ToolBar.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8089134: [2D traversal, RTL] TraversalEngine only handles left/right key traversal correctly in RTL for top-level engine in ToolBar

Reviewers

• Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/144/head:pull/144
$ git checkout pull/144

[bridgekeeper]

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (7f86ceb)

[openjdk]

@aghaisas This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8089134: [2D traversal, RTL] TraversalEngine only handles left/right key traversal correctly in RTL for top-level engine in ToolBar

Reviewed-by: kcr

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2a7ab367329525636e677979bfa6b9b09e3d1136.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[aghaisas]

/integrate

[openjdk]

@aghaisas The following commits have been pushed to master since your change was applied:

• 2aa8218: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation
• e9c6119: 8240692: Cleanup of the javafx property objects

Your commit was automatically rebased without conflicts.

Pushed as commit 2a7ab36.