Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242839: Create release notes for JavaFX 14.0.1 #186

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Apr 17, 2020

Add release notes for 14.0.1
Fix for JDK-8242839


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/186/head:pull/186
$ git checkout pull/186

Fix for JDK-8242839
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2020

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into jfx14 will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Apr 17, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 17, 2020

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242839: Create release notes for JavaFX 14.0.1

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the jfx14 branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate a2369b1ca1cd11c922756967309d3377e56c2d3f.

➡️ To integrate this PR with the above commit message to the jfx14 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Apr 17, 2020
@johanvos
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Apr 17, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Apr 17, 2020
@openjdk
Copy link

openjdk bot commented Apr 17, 2020

@johanvos
Pushed as commit 331a39b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants