Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244824: TableView : Incorrect German translation #220

Closed
wants to merge 1 commit into from

Conversation

@aghaisas
Copy link
Collaborator

aghaisas commented May 15, 2020

Issue : https://bugs.openjdk.java.net/browse/JDK-8244824

Fix : As simple as it gets !!!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8244824: TableView : Incorrect German translation

Reviewers

  • Jeanette Winzenburg (fastegal - Author)
  • Kevin Rushforth (kcr - Reviewer)

Contributors

  • Martin Schelldorfer <schelldorfer@gmail.com>

Download

$ git fetch https://git.openjdk.java.net/jfx pull/220/head:pull/220
$ git checkout pull/220

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 15, 2020
@mlbridge
Copy link

mlbridge bot commented May 15, 2020

Webrevs

@danielpeintner
Copy link

danielpeintner commented May 15, 2020

FYI: While I agree "Inhalt" is better than "Content" the latter is not completely wrong (see https://www.duden.de/rechtschreibung/Content)

Copy link
Collaborator

kleopatra left a comment

Correct :)

@aghaisas
Copy link
Collaborator Author

aghaisas commented May 19, 2020

@kevinrushforth brought to my notice that there is a PR (#210) opened for the same issue by schelldorfer. I was not aware of this PR as it did not have 'rfr' label - which I look for.
I picked up this issue from JBS and submitted the solution mentioned in JBS.

I would NOT like to step on a new contributor's contribution.

Now, I see that the original PR has been closed. Once his signed OCA has been recorded, we have two options :

  1. I will integrate with this PR with due attribution given to schelldorfer
    OR
  2. I will withdraw my PR without integrating and schelldorfer can reopen and submit his PR.
@kevinrushforth
Copy link
Member

kevinrushforth commented May 19, 2020

@aghaisas that sounds fine to me. In order to attribute the fix, you will need to wait for the OCA to be recorded.

@schelldorfer once your OCA is recorded, which would you prefer to do? Create a new PR yourself or have @aghaisas list you as the contributor.

@schelldorfer
Copy link
Contributor

schelldorfer commented May 19, 2020

I signed the OCA a few days ago and my name is listed on the page
https://www.oracle.com/technetwork/community/oca-486395.html#s

@schelldorfer
Copy link
Contributor

schelldorfer commented Jun 12, 2020

@aghaisas can you proceed with this one or is there anything required from my side?

@aghaisas
Copy link
Collaborator Author

aghaisas commented Jun 12, 2020

I need confirmation from you about which option you prefer (See my last comment above). @kevinrushforth also has asked the same question in his last comment.

@schelldorfer
Copy link
Contributor

schelldorfer commented Jun 12, 2020

let's do option 1

@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@aghaisas This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244824: TableView : Incorrect German translation

Co-authored-by: Martin Schelldorfer <schelldorfer@gmail.com>
Reviewed-by: fastegal, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 24 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b2b46eb3b53ca1818843786b576d7501a909e126.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 12, 2020
@aghaisas
Copy link
Collaborator Author

aghaisas commented Jun 12, 2020

/contributor schelldorfer

@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@aghaisas Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>
@aghaisas
Copy link
Collaborator Author

aghaisas commented Jun 12, 2020

/contributor @schelldorfer

@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@aghaisas Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>
@aghaisas
Copy link
Collaborator Author

aghaisas commented Jun 12, 2020

/contributor add @schelldorfer

@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@aghaisas Could not parse @schelldorfer as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>
@aghaisas
Copy link
Collaborator Author

aghaisas commented Jun 12, 2020

/contributor add Martin Schelldorfer schelldorfer@gmail.com

@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@aghaisas
Contributor Martin Schelldorfer <schelldorfer@gmail.com> successfully added.

@aghaisas
Copy link
Collaborator Author

aghaisas commented Jun 12, 2020

/integrate

@openjdk openjdk bot closed this Jun 12, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 12, 2020
@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@aghaisas The following commits have been pushed to master since your change was applied:

  • b2b46eb: 8242892: SpinnerValueFactory has an implicit no-arg constructor
  • afa805f: 8245575: Show the ContextMenu of input controls with long press gesture on iOS
  • 5304266: 8245635: GlassPasteboard::getUTFs fails on iOS
  • ba501ef: 8246357: Allow static build of webkit library on linux
  • a02e09d: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
  • 9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux
  • 6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
  • 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
  • a78b3fb: 8242523: Update the animation and clip envelope classes
  • 1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
  • 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
  • 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
  • 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
  • c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
  • 3ceee69: 8245499: Text input controls should show handles on iOS
  • 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
  • 16f446a: 8234876: Unit test classes should not extend Application
  • 2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
  • f3190db: 8244531: Tests: add support to identify recurring issues with controls et al
  • 1971c70: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest
  • 6e0b45a: 8245183: Two fxml unit tests log warnings about deprecated escape sequences
  • a13a642: 8244579: Windows "User Objects" leakage with WebView
  • 37b5edc: 8245456: MacPasteboard throws ClassCastException on static builds
  • 6e03930: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

Your commit was automatically rebased without conflicts.

Pushed as commit b200891.

@openjdk openjdk bot removed the rfr label Jun 12, 2020
@aghaisas aghaisas deleted the aghaisas:translation_fix branch Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.