8244824: TableView : Incorrect German translation #220

aghaisas · 2020-05-15T06:49:04Z

Issue : https://bugs.openjdk.java.net/browse/JDK-8244824

Fix : As simple as it gets !!!

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8244824: TableView : Incorrect German translation

Reviewers

Jeanette Winzenburg (fastegal - Author)
Kevin Rushforth (kcr - Reviewer)

Contributors

Martin Schelldorfer <schelldorfer@gmail.com>

Download

$ git fetch https://git.openjdk.java.net/jfx pull/220/head:pull/220
$ git checkout pull/220

bridgekeeper · 2020-05-15T06:50:25Z

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

mlbridge · 2020-05-15T06:54:47Z

Webrevs

00: Full (8854942)

danielpeintner · 2020-05-15T07:18:36Z

FYI: While I agree "Inhalt" is better than "Content" the latter is not completely wrong (see https://www.duden.de/rechtschreibung/Content)

kleopatra

Correct :)

aghaisas · 2020-05-19T14:27:40Z

@kevinrushforth brought to my notice that there is a PR (#210) opened for the same issue by schelldorfer. I was not aware of this PR as it did not have 'rfr' label - which I look for.
I picked up this issue from JBS and submitted the solution mentioned in JBS.

I would NOT like to step on a new contributor's contribution.

Now, I see that the original PR has been closed. Once his signed OCA has been recorded, we have two options :

I will integrate with this PR with due attribution given to schelldorfer
OR
I will withdraw my PR without integrating and schelldorfer can reopen and submit his PR.

kevinrushforth · 2020-05-19T14:38:01Z

@aghaisas that sounds fine to me. In order to attribute the fix, you will need to wait for the OCA to be recorded.

@schelldorfer once your OCA is recorded, which would you prefer to do? Create a new PR yourself or have @aghaisas list you as the contributor.

schelldorfer · 2020-05-19T16:28:16Z

I signed the OCA a few days ago and my name is listed on the page
https://www.oracle.com/technetwork/community/oca-486395.html#s

schelldorfer · 2020-06-12T10:01:52Z

@aghaisas can you proceed with this one or is there anything required from my side?

aghaisas · 2020-06-12T10:29:08Z

I need confirmation from you about which option you prefer (See my last comment above). @kevinrushforth also has asked the same question in his last comment.

schelldorfer · 2020-06-12T11:49:21Z

let's do option 1

openjdk · 2020-06-12T12:32:22Z

@aghaisas This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244824: TableView : Incorrect German translation

Co-authored-by: Martin Schelldorfer <schelldorfer@gmail.com>
Reviewed-by: fastegal, kcr

If you would like to add a summary, use the /summary command.
To credit additional contributors, use the /contributor command.
To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 24 commits pushed to the master branch:

b2b46eb: 8242892: SpinnerValueFactory has an implicit no-arg constructor
afa805f: 8245575: Show the ContextMenu of input controls with long press gesture on iOS
5304266: 8245635: GlassPasteboard::getUTFs fails on iOS
ba501ef: 8246357: Allow static build of webkit library on linux
a02e09d: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux
6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
a78b3fb: 8242523: Update the animation and clip envelope classes
1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
... and 14 more: https://git.openjdk.java.net/jfx/compare/bb2432241bcf0ec1add651b995d4ada6676b4cc3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b2b46eb3b53ca1818843786b576d7501a909e126.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

aghaisas · 2020-06-12T12:35:54Z

/contributor schelldorfer

openjdk · 2020-06-12T12:36:01Z

@aghaisas Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

aghaisas · 2020-06-12T12:36:58Z

/contributor @schelldorfer

openjdk · 2020-06-12T12:37:09Z

@aghaisas Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

aghaisas · 2020-06-12T12:37:40Z

/contributor add @schelldorfer

openjdk · 2020-06-12T12:37:54Z

@aghaisas Could not parse @schelldorfer as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

aghaisas · 2020-06-12T12:45:29Z

/contributor add Martin Schelldorfer schelldorfer@gmail.com

openjdk · 2020-06-12T12:45:38Z

@aghaisas
Contributor Martin Schelldorfer <schelldorfer@gmail.com> successfully added.

aghaisas · 2020-06-12T12:47:46Z

/integrate

openjdk · 2020-06-12T12:48:13Z

@aghaisas The following commits have been pushed to master since your change was applied:

b2b46eb: 8242892: SpinnerValueFactory has an implicit no-arg constructor
afa805f: 8245575: Show the ContextMenu of input controls with long press gesture on iOS
5304266: 8245635: GlassPasteboard::getUTFs fails on iOS
ba501ef: 8246357: Allow static build of webkit library on linux
a02e09d: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux
6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
a78b3fb: 8242523: Update the animation and clip envelope classes
1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
168b7f7: 8246099: Intermittent test failures in SandboxAppTest
c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
3ceee69: 8245499: Text input controls should show handles on iOS
8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
16f446a: 8234876: Unit test classes should not extend Application
2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
f3190db: 8244531: Tests: add support to identify recurring issues with controls et al
1971c70: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest
6e0b45a: 8245183: Two fxml unit tests log warnings about deprecated escape sequences
a13a642: 8244579: Windows "User Objects" leakage with WebView
37b5edc: 8245456: MacPasteboard throws ClassCastException on static builds
6e03930: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

Your commit was automatically rebased without conflicts.

Pushed as commit b200891.

German translation bug fix

8854942

openjdk bot added the rfr Ready for review label May 15, 2020

kleopatra approved these changes May 15, 2020

View reviewed changes

kevinrushforth approved these changes Jun 12, 2020

View reviewed changes

openjdk bot added the ready Ready to be integrated label Jun 12, 2020

openjdk bot closed this Jun 12, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated labels Jun 12, 2020

openjdk bot removed the rfr Ready for review label Jun 12, 2020

aghaisas deleted the translation_fix branch July 27, 2020 04:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8244824: TableView : Incorrect German translation #220

8244824: TableView : Incorrect German translation #220

aghaisas commented May 15, 2020 •

edited by openjdk bot

bridgekeeper bot commented May 15, 2020

mlbridge bot commented May 15, 2020

danielpeintner commented May 15, 2020 •

edited by bridgekeeper bot

kleopatra left a comment

aghaisas commented May 19, 2020

kevinrushforth commented May 19, 2020

schelldorfer commented May 19, 2020 •

edited by bridgekeeper bot

schelldorfer commented Jun 12, 2020

aghaisas commented Jun 12, 2020

schelldorfer commented Jun 12, 2020

openjdk bot commented Jun 12, 2020 •

edited

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

8244824: TableView : Incorrect German translation #220

8244824: TableView : Incorrect German translation #220

Conversation

aghaisas commented May 15, 2020 • edited by openjdk bot

Progress

Issue

Reviewers

Contributors

Download

bridgekeeper bot commented May 15, 2020

mlbridge bot commented May 15, 2020

Webrevs

danielpeintner commented May 15, 2020 • edited by bridgekeeper bot

kleopatra left a comment

Choose a reason for hiding this comment

aghaisas commented May 19, 2020

kevinrushforth commented May 19, 2020

schelldorfer commented May 19, 2020 • edited by bridgekeeper bot

schelldorfer commented Jun 12, 2020

aghaisas commented Jun 12, 2020

schelldorfer commented Jun 12, 2020

openjdk bot commented Jun 12, 2020 • edited

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented Jun 12, 2020

openjdk bot commented Jun 12, 2020

aghaisas commented May 15, 2020 •

edited by openjdk bot

danielpeintner commented May 15, 2020 •

edited by bridgekeeper bot

schelldorfer commented May 19, 2020 •

edited by bridgekeeper bot

openjdk bot commented Jun 12, 2020 •

edited