Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars #249

Closed
wants to merge 8 commits into from
Closed

8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars #249

wants to merge 8 commits into from

Commits on Jun 9, 2020

  1. Use number of real characters when obtaining pointers in a string. 

    A surrogate pair only counts for 1 character (and not for 2).
This fixes JDK-8246348
    @johanvos
    johanvos committed Jun 9, 2020
    Copy the full SHA
    0eed97d View commit details
    Browse the repository at this point in the history

  2. allow different TextRuns to share the same UTF 16 text, but create se… 

    …parate

UTF 8 strings for each TextRun
    @johanvos
    johanvos committed Jun 9, 2020
    Copy the full SHA
    e9184be View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Add check for 0 in text 

    Add test that will fail on Ubuntu 20.04 if this PR is not applied.
The test is currently commented, as PGFont.getResource returns null
for fonts in testing.
    @johanvos
    johanvos committed Jun 10, 2020
    Copy the full SHA
    d345c74 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. process reviewer comments: start == str 

    check on 0 char not needed anymore
    @johanvos
    johanvos committed Jun 12, 2020
    Copy the full SHA
    998f55c View commit details
    Browse the repository at this point in the history

  2. use LinkedHashMap instead of HashMap 

    Only store the pointer to the utf8 string if its creation was successful
    @johanvos
    johanvos committed Jun 12, 2020
    Copy the full SHA
    0d6e909 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Add test for testing Pango behavior with Character(0) and surrogate p… 

    …airs
    @johanvos
    johanvos committed Jun 15, 2020
    Copy the full SHA
    8c6e73a View commit details
    Browse the repository at this point in the history

  2. use latest patterns in system test 

    revert ignored test in :graphics
    @johanvos
    johanvos committed Jun 15, 2020
    Copy the full SHA
    cc178e7 View commit details
    Browse the repository at this point in the history

  3. remove trailing whitespace

    @johanvos
    johanvos committed Jun 15, 2020
    Copy the full SHA
    889c013 View commit details
    Browse the repository at this point in the history