Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy PR to test error reporting after GitHub Actions are enabled #339

Closed
wants to merge 3 commits into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 27, 2020

This PR is intended only for testing purposes to show what will happen after the GitHub Actions build / test runs are enabled in PR #33

In this example I have injected a build failure on Windows and a test failure on Mac. Linux should pass. I'm only interested in how these failures are reported by Skara in this dummy PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build / test ✔️ (1/1 passed) ❌ (1/1 failed) ❌ (1/1 failed)

Failed test tasks

Download

$ git fetch https://git.openjdk.java.net/jfx pull/339/head:pull/339
$ git checkout pull/339

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member Author

The above test results are as expected.

As a possible follow-up RFE it might be helpful if the results showed whether it was the build step or the test step that failed, but it's easy enough to look at the failing workflow and see that, so that can be a future enhancement. We would need to discuss with the Skara folks about what changes would be needed on our end and/or their end.

@kevinrushforth kevinrushforth deleted the err-pr-338 branch November 3, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant