Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255723: Gtk glass backend should run with Gtk+ 3.8 (minimum) #346

Closed
wants to merge 11 commits into from

Conversation

tsayao
Copy link
Collaborator

@tsayao tsayao commented Nov 2, 2020

Simple fix to not build with GTK+ greater than 3.8 symbols.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build / test ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed)

Issue

  • JDK-8255723: Gtk glass backend should run with Gtk+ 3.8 (minimum)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/346/head:pull/346
$ git checkout pull/346

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2020

👋 Welcome back tsayao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Nov 2, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2020

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In general we shouldn't use compile-time version checks for OS or platform software, since the binaries we produce should run on anything greater than the minimum. I see we still have a few, but the rest are at least consistently no greater than 3.8.

@openjdk
Copy link

openjdk bot commented Nov 3, 2020

@tsayao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255723: Gtk glass backend should run with Gtk+ 3.8 (minimum)

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • eece20b: 8255714: Switch FX build to use JDK 15.0.1 as boot JDK
  • c31ed6b: 8255415: Nested calls to snap methods in Region give different results

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Nov 3, 2020
@tsayao
Copy link
Collaborator Author

tsayao commented Nov 4, 2020

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Nov 4, 2020
@openjdk
Copy link

openjdk bot commented Nov 4, 2020

@tsayao
Your change (at version 4f589df) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Nov 4, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Ready to sponsor ready Ready to be integrated labels Nov 4, 2020
@openjdk
Copy link

openjdk bot commented Nov 4, 2020

@kevinrushforth @tsayao Since your change was applied there have been 2 commits pushed to the master branch:

  • eece20b: 8255714: Switch FX build to use JDK 15.0.1 as boot JDK
  • c31ed6b: 8255415: Nested calls to snap methods in Region give different results

Your commit was automatically rebased without conflicts.

Pushed as commit 92804f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Ready for review label Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants