Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams #526

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Jun 3, 2021

With recent GStreamer update gstmpegaudioparse no longer provides audio buffers with valid timestamps. This issue is only reproducible with MP3 HTTP Live Stream and was noticed on Linux. I think Windows audio decoder handles such case better and thus MP3 HLS works fine. I did not figure out why it behaves this way and for now fix is reverting gstmpegaudioparse changeset which caused it. Follow up issue will be filed to investigate why javasource and/or hlsprogressbuffer no longer compatible with gstmpegaudioparse and gstmpegaudioparse cannot figure out correct PTS. Also, fixed potential null pointer reference for buffers with invalid PTS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/526/head:pull/526
$ git checkout pull/526

Update a local copy of the PR:
$ git checkout pull/526
$ git pull https://git.openjdk.java.net/jfx pull/526/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 526

View PR using the GUI difftool:
$ git pr show -t 526

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/526.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 3, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 3, 2021

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 3, 2021

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I did a build / test on all three platforms.

arapte
arapte approved these changes Jun 4, 2021
Copy link
Member

@arapte arapte left a comment

looks good to me, tested on windows and Linux.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 47700d8: 8267819: CoInitialize/CoUninitialize should be called on same thread

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 4, 2021
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Jun 5, 2021

/integrate

@openjdk openjdk bot closed this Jun 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@sashamatveev Since your change was applied there has been 1 commit pushed to the master branch:

  • 47700d8: 8267819: CoInitialize/CoUninitialize should be called on same thread

Your commit was automatically rebased without conflicts.

Pushed as commit ee03238.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants