-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams #526
Conversation
👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I did a build / test on all three platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, tested on windows and Linux.
@sashamatveev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@sashamatveev Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ee03238. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
With recent GStreamer update gstmpegaudioparse no longer provides audio buffers with valid timestamps. This issue is only reproducible with MP3 HTTP Live Stream and was noticed on Linux. I think Windows audio decoder handles such case better and thus MP3 HLS works fine. I did not figure out why it behaves this way and for now fix is reverting gstmpegaudioparse changeset which caused it. Follow up issue will be filed to investigate why javasource and/or hlsprogressbuffer no longer compatible with gstmpegaudioparse and gstmpegaudioparse cannot figure out correct PTS. Also, fixed potential null pointer reference for buffers with invalid PTS.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/526/head:pull/526
$ git checkout pull/526
Update a local copy of the PR:
$ git checkout pull/526
$ git pull https://git.openjdk.java.net/jfx pull/526/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 526
View PR using the GUI difftool:
$ git pr show -t 526
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/526.diff