8251481: TableCell accessing row: NPE on auto-sizing

[Maran23]

This PR will fix a simple NPE which may happens when using the TableRow inside a TableCell during the initial auto sizing.
In the auto sizing code, no TableRow is set, therefore getTableRow() will return null and it is not possible to e.g. access the row item.

This is fixed by adding the TableRow in the resizeColumnToFitContent method, similar as it is already done for the TreeTableView (TreeTableRow).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8251481: TableCell accessing row: NPE on auto-sizing

Reviewers

• Jeanette Winzenburg (@kleopatra - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/716/head:pull/716
$ git checkout pull/716

Update a local copy of the PR:
$ git checkout pull/716
$ git pull https://git.openjdk.java.net/jfx pull/716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 716

View PR using the GUI difftool:
$ git pr show -t 716

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/716.diff

[bridgekeeper]

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 03: Full - Incremental (a706068e)
• 02: Full - Incremental (a8d99555)
• 01: Full - Incremental (30dd77e9)
• 00: Full (0ba6b283)

[kleopatra]

hmm .. I think here are two issues:

• the auto-sizing code definitely needs to fully configure the cell (with index, row, column, tableView plus applying css) to measure the correct size
• the implementation of cell.updateItem (even though it's my own ;) is a bit fishy: does its spec really guarantee that getTableRow() != null if !empty()? Meanwhile, I think that's not the case - but then, it's for demonstrating the first bullet :)

The first is fixed by this PR (looks good on first sight). The second might need a clarification in the method doc .. or not, undecided.

[Maran23]

hmm .. I think here are two issues:

• the auto-sizing code definitely needs to fully configure the cell (with index, row, column, tableView plus applying css) to measure the correct size
• the implementation of cell.updateItem (even though it's my own ;) is a bit fishy: does its spec really guarantee that getTableRow() != null if !empty()? Meanwhile, I think that's not the case - but then, it's for demonstrating the first bullet :)

The first is fixed by this PR (looks good on first sight). The second might need a clarification in the method doc .. or not, undecided.

Yes the auto sizing has some more issues.
While looking on it, I found two problems which should be done as follow-up:

1. Both resizeColumnToFitContent methods do not use the row factory of the corresponding table (minor, but still something which should be improved here)
2. Currently both implementation add the TableCell directly into the TableSkin, which is not how it is usually done. Normally the TableRow is added (by the VirtualFlow), therefore the example of the related ticket JDK-8251480 won't work after this fix, but may do when the TableRow is added instead (didn't tested it though)

May both can be addressed in future via JDK-8251480

[kleopatra]

fix looks good: verified that the bug example doesn't throw after the fix, also that the test failed/passed before/after the fix

left a couple of inline comments for the test

[kleopatra]

looks good (there's one minor thingy in completely aligning the test for TreeTable)

[openjdk]

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8251481: TableCell accessing row: NPE on auto-sizing

Reviewed-by: fastegal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• ee52d14: 8277122: SplitPane divider drag can hang the layout
• 78d9227: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning
• ae334c5: 8279013: ES2Pipeline fails to detect AMD vega20 graphics card
• 92b10aa: Merge
• c47f18e: 8280280: Update boot JDK to 17.0.2
• 217e086: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage
• 94807b6: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases
• 4c79c54: 8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed
• f01c50d: Merge
• 7a1a19c: 8273998: Clarify specification for Window properties controlled by the window manager
• ... and 12 more: https://git.openjdk.java.net/jfx/compare/dd096783b806a7a5f803292adb3fbd9ddfb047f5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kleopatra) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kleopatra]

okay

[Maran23]

/integrate

[openjdk]

@Maran23
Your change (at version a706068) is now ready to be sponsored by a Committer.

[kleopatra]

/sponsor

[openjdk]

Going to push as commit 59cd8ec.
Since your change was applied there have been 22 commits pushed to the master branch:

• ee52d14: 8277122: SplitPane divider drag can hang the layout
• 78d9227: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning
• ae334c5: 8279013: ES2Pipeline fails to detect AMD vega20 graphics card
• 92b10aa: Merge
• c47f18e: 8280280: Update boot JDK to 17.0.2
• 217e086: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage
• 94807b6: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases
• 4c79c54: 8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed
• f01c50d: Merge
• 7a1a19c: 8273998: Clarify specification for Window properties controlled by the window manager
• ... and 12 more: https://git.openjdk.java.net/jfx/compare/dd096783b806a7a5f803292adb3fbd9ddfb047f5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kleopatra @Maran23 Pushed as commit 59cd8ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.