8288137: The set of available printers is not updated without application restart

[prrace]

This fixes the issue that the default printer or set of available printers is fixed from the first call to it in the lifetime of the application.
Now subsequent calls will check to see if there are changes.
A manual test is provided for verifying this - it requires you to add/remove printers at the system level to verify anything related to this fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8288137: The set of available printers is not updated without application restart

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/817/head:pull/817
$ git checkout pull/817

Update a local copy of the PR:
$ git checkout pull/817
$ git pull https://git.openjdk.org/jfx pull/817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 817

View PR using the GUI difftool:
$ git pr show -t 817

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/817.diff

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

I tested it on Windows by adding and removing a printer, and it does what I would expect. I left a couple questions on the implementation, along with a minor formatting issue. You'll also need to fix the whitespace error that jcheck reported.

[mlbridge]

Webrevs

• 03: Full - Incremental (490e17da)
• 02: Full - Incremental (21ec7bdd)
• 01: Full - Incremental (4932450c)
• 00: Full (0cb60d76)

[kevinrushforth]

The changes to when lastTime is stored looks good (both of them). I just noticed that the test is backwards, though.

[arapte]

Verified that available printers get updated correctly, by running provided test.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288137: The set of available printers is not updated without application restart

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 8d5d3ca: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses
• 437c078: 8289255: update Eclipse .classpath and other configuration files
• 13f3e1f: 8289395: Fix warnings: Varargs methods should only override or be overridden by other varargs methods
• c7d3fd9: 8283402: Update to gcc 11.2 on Linux
• cbb53b2: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build
• 187fbe1: 8289381: Fix warnings: The assignment to variable has no effect
• 60c75b8: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue
• 178d898: 8276056: Control.skin.setSkin(Skin) fails to call dispose() on discarded Skin
• fc6a602: 8289587: IllegalArgumentException: Color.rgb's red parameter (-16776961) expects color values 0-255

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

/integrate

[openjdk]

Going to push as commit b9a1ec5.
Since your change was applied there have been 10 commits pushed to the master branch:

• 0132ac8: 8284676: TreeTableView loses sort ordering when applied on empty table
• 8d5d3ca: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses
• 437c078: 8289255: update Eclipse .classpath and other configuration files
• 13f3e1f: 8289395: Fix warnings: Varargs methods should only override or be overridden by other varargs methods
• c7d3fd9: 8283402: Update to gcc 11.2 on Linux
• cbb53b2: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build
• 187fbe1: 8289381: Fix warnings: The assignment to variable has no effect
• 60c75b8: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue
• 178d898: 8276056: Control.skin.setSkin(Skin) fails to call dispose() on discarded Skin
• fc6a602: 8289587: IllegalArgumentException: Color.rgb's red parameter (-16776961) expects color values 0-255

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit b9a1ec5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.