New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6941: build.sh does not terminate jetty after executing '--packageJmc' #130
Conversation
Signed-off-by: Patrick Reinhart <patrick@reini.net>
👋 Welcome back reinhapa! A progress list of the required criteria for merging this PR into |
I checked the pull-request with Linux Mint jmc git:(pull-request) ✗ ./build.sh --packageJmc[20/10/16| 1:10PM] ➜ jmc git:(pull-request) ✗ build.sh --run [20/10/16| 1:18PM] Use jcmd 1004545 JFR.dump name=JMC_Default filename=FILEPATH to copy recording data to file. |
@petrbouda was the successful for you? I personally tested it successfully on Fedora Linux & Mac OS so far... |
@reinhapa Yeap, it looks good. I tested it on Linux Mint (Ubuntu), built the artifact, and started it up using |
@reinhapa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@thegreystone @reinhapa Pushed as commit 8129edd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
stopping jetty instance using kill command working on Mac & Linux
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jmc pull/130/head:pull/130
$ git checkout pull/130