Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6941: build.sh does not terminate jetty after executing '--packageJmc' #130

Closed
wants to merge 1 commit into from

Conversation

@reinhapa
Copy link
Member

@reinhapa reinhapa commented Oct 15, 2020

stopping jetty instance using kill command working on Mac & Linux


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

linux mac win
Build / test ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed)

Issue

  • JMC-6941: build.sh does not terminate jetty after executing '--packageJmc'

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/130/head:pull/130
$ git checkout pull/130

Signed-off-by: Patrick Reinhart <patrick@reini.net>
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 15, 2020

👋 Welcome back reinhapa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 15, 2020

Webrevs

@petrbouda
Copy link

@petrbouda petrbouda commented Oct 16, 2020

I checked the pull-request with Linux Mint

jmc git:(pull-request) ✗ ./build.sh --packageJmc[20/10/16| 1:10PM]
13:10:15 building p2:site - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.1.p2_site.log
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/home/pbouda/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
13:10:24 run jetty - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.2.jetty.log
13:10:24 waiting for jetty server to start
13:10:25 waiting for jetty server to start
13:10:26 waiting for jetty server to start
13:10:27 jetty server up and running on pid 999930
13:10:27 installing core artifacts - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.3.install.log
13:11:48 packaging jmc - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.4.package.log
You can now run jmc by calling "build.sh --run" or "/home/pbouda/experiments/jmc/target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\ Control/jmc"
13:18:44 terminating jetty server

➜ jmc git:(pull-request) ✗ build.sh --run [20/10/16| 1:18PM]
OpenJDK 64-Bit Server VM warning: Option FlightRecorder was deprecated in version 13.0 and will likely be removed in a future release.
Started recording 1.

Use jcmd 1004545 JFR.dump name=JMC_Default filename=FILEPATH to copy recording data to file.

@reinhapa
Copy link
Member Author

@reinhapa reinhapa commented Oct 16, 2020

@petrbouda was the successful for you? I personally tested it successfully on Fedora Linux & Mac OS so far...

@petrbouda
Copy link

@petrbouda petrbouda commented Oct 16, 2020

@reinhapa Yeap, it looks good. I tested it on Linux Mint (Ubuntu), built the artifact, and started it up using build.sh --run

@thegreystone thegreystone self-requested a review Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@reinhapa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6941: build.sh does not terminate jetty after executing '--packageJmc'

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 16, 2020
@reinhapa
Copy link
Member Author

@reinhapa reinhapa commented Oct 16, 2020

/integrate

@openjdk openjdk bot added the sponsor label Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@reinhapa
Your change (at version 51a2e9c) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Oct 16, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@thegreystone @reinhapa Pushed as commit 8129edd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@reinhapa reinhapa deleted the JMC-6941 branch Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants