New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6832: Should allow plotting line charts for all quantities #255
Conversation
Hi @ojung, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ojung" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
e46b985
to
1b97bce
Compare
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Hi, Please send me an e-mail at Dalibor.topic@oracle.com so that I can mark your account as verified. |
I noticed I wasn't able to plot quite all quantities in line charts so far. Closing for the moment and opening another PR if/when I finish this. |
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/255/head:pull/255
$ git checkout pull/255
Update a local copy of the PR:
$ git checkout pull/255
$ git pull https://git.openjdk.java.net/jmc pull/255/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 255
View PR using the GUI difftool:
$ git pr show -t 255
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/255.diff