Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6832: Should allow plotting line charts for all quantities #255

Closed
wants to merge 4 commits into from

Conversation

@ojung
Copy link
Contributor

@ojung ojung commented May 28, 2021


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6832: Should allow plotting line charts for all quantities

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/255/head:pull/255
$ git checkout pull/255

Update a local copy of the PR:
$ git checkout pull/255
$ git pull https://git.openjdk.java.net/jmc pull/255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 255

View PR using the GUI difftool:
$ git pr show -t 255

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/255.diff

@ojung ojung changed the title 6832 Allow plotting line charts in more places 6832: Allow plotting line charts in more places May 28, 2021
@bridgekeeper bridgekeeper bot added the oca label May 28, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2021

Hi @ojung, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ojung" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@ojung ojung force-pushed the 6832-allow-plotting-line-charts branch from e46b985 to 1b97bce May 28, 2021
@ojung ojung changed the title 6832: Allow plotting line charts in more places 6832: Should allow plotting line charts for all quantities May 28, 2021
@ojung
Copy link
Contributor Author

@ojung ojung commented May 28, 2021

/covered

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@robilad
Copy link

@robilad robilad commented May 28, 2021

Hi,

Please send me an e-mail at Dalibor.topic@oracle.com so that I can mark your account as verified.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 1, 2021

Webrevs

@ojung
Copy link
Contributor Author

@ojung ojung commented Jun 1, 2021

I noticed I wasn't able to plot quite all quantities in line charts so far. Closing for the moment and opening another PR if/when I finish this.

@ojung ojung closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants