Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7353: JMC fails to build because it can't download babel dependency #281

Closed
wants to merge 1 commit into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Jul 23, 2021

This PR addresses JMC-7353 [0] (and JMC-7356 [1]), in which JMC cannot build because the babel dependency is unable to be downloaded:

[ERROR] All attempts to read artifact osgi.bundle,org.eclipse.compare.core.nl_ja,4.19.0.v20210327020002 failed:
[ERROR] An error occurred while transferring artifact canonical: osgi.bundle,org.eclipse.compare.core.nl_ja,4.19.0.v20210327020002 from repository
https://archive.eclipse.org/technology/babel/update-site/R0.18.3/2021-03

This is due to a recent update to babel for platforms 2020-12 and 2021-03 (and 2021-06, but that doesn't affect us yet ..) [2], which resulted in a new url being required to fetch the current supported version of babel for 2021-03. This PR updates the url and version of babel for the 2021-03 target platform.

Note that there is also an updated link for the 2020-12 babel, but the older babel isn't causing any problems downloading at the moment, so I've decided to only update the 2021-03 target platform here.

To verify this you can blow-up your ~/.m2 folder and try a clean install with 2021-03 as the active platform.

[0] https://bugs.openjdk.java.net/browse/JMC-7353
[1] https://bugs.openjdk.java.net/browse/JMC-7356
[2] https://www.eclipse.org/babel/downloads.php


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7353: JMC fails to build because it can't download babel dependency

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/281/head:pull/281
$ git checkout pull/281

Update a local copy of the PR:
$ git checkout pull/281
$ git pull https://git.openjdk.java.net/jmc pull/281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 281

View PR using the GUI difftool:
$ git pr show -t 281

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/281.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2021

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 23, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2021

Webrevs

@thegreystone
Copy link
Member

thegreystone commented Jul 23, 2021

Thanks for looking into this Alex!

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7353: JMC fails to build because it can't download babel dependency

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 23, 2021
@aptmac
Copy link
Member Author

aptmac commented Jul 23, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

Going to push as commit 0113da9.

@openjdk openjdk bot closed this Jul 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 23, 2021
@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@aptmac Pushed as commit 0113da9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the 7353 branch Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants