7902804: -prof async help messages should mention DYLD_LIBRARY_PATH for Mac OS users #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/issue CODETOOLS-7902804 |
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This issue is referenced in the PR title - it will now be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS needs DYLD_LIBRARY_PATH to be set, not LD_LIBRARY_PATH. Plus, we might want to point out that libPath is available to work-around async-profiler naming issue:
async-profiler/async-profiler#378
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/jmh pull/11/head:pull/11$ git checkout pull/11