Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JUnit 4.13.2 #24

Closed
wants to merge 1 commit into from

Conversation

henri-tremblay
Copy link
Contributor

@henri-tremblay henri-tremblay commented Feb 23, 2021


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmh pull/24/head:pull/24
$ git checkout pull/24

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Feb 23, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2021

Hi @henri-tremblay, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user henri-tremblay" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@henri-tremblay
Copy link
Contributor Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Feb 23, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2021

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. We need to wait for @robilad to get OCA checks all green.

@henri-tremblay
Copy link
Contributor Author

Ok. I'm not sure if I need to do anything on my side. I have already signed the OCA but I don't think it's linked to my Github account.

@robilad
Copy link

robilad commented Mar 5, 2021

Hi Henry,

I sent an e-mail to the account listed in your OCA. When you reply, I can mark the account as verified. Thanks!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Mar 9, 2021
@openjdk
Copy link

openjdk bot commented Mar 9, 2021

@henri-tremblay This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Upgrade to JUnit 4.13.2

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 41548a7: CODETOOLS-7902834: JMHSample_25_API_GA selectToBreed selection bug
  • 3787066: CODETOOLS-7902839: JMH: Replace the use of ThreadLocal with explicitly managed thread map
  • f8eef4a: CODETOOLS-7902841: JMH: Reflow JMH file locking code
  • 3b7bab9: CODETOOLS-7902840: JMH: Fix *Statistics iterators to throw NoSuchElementException properly
  • ec0740c: CODETOOLS-7902838: JMH: Don't use fail() inside a try-catch catching an AssertionError
  • f3e7d82: Continue in 1.29-SNAPSHOT
  • 6ffede8: JMH v1.28.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 9, 2021

Webrevs

@shipilev
Copy link
Member

@henri-tremblay, look at what bot says to you, say /integrate.

@henri-tremblay
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 10, 2021
@openjdk
Copy link

openjdk bot commented Mar 10, 2021

@henri-tremblay
Your change (at version e6c0a58) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Mar 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Mar 10, 2021
@openjdk
Copy link

openjdk bot commented Mar 10, 2021

@shipilev @henri-tremblay Since your change was applied there have been 7 commits pushed to the master branch:

  • 41548a7: CODETOOLS-7902834: JMHSample_25_API_GA selectToBreed selection bug
  • 3787066: CODETOOLS-7902839: JMH: Replace the use of ThreadLocal with explicitly managed thread map
  • f8eef4a: CODETOOLS-7902841: JMH: Reflow JMH file locking code
  • 3b7bab9: CODETOOLS-7902840: JMH: Fix *Statistics iterators to throw NoSuchElementException properly
  • ec0740c: CODETOOLS-7902838: JMH: Don't use fail() inside a try-catch catching an AssertionError
  • f3e7d82: Continue in 1.29-SNAPSHOT
  • 6ffede8: JMH v1.28.

Your commit was automatically rebased without conflicts.

Pushed as commit 01ae29c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants