Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7903094: JMH: Replace Math.log with predictable code in samples #60

Merged
merged 1 commit into from Feb 10, 2022

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 9, 2022

Looks like Math.log is no longer intrinsified into C2 IR, so dead code / constant fold examples no longer work. It seems to have started since JDK 9 and JDK-8152907 that now defers the computation of Math.log to quick LIBM stub. It does, however, limits the compiler optimizations around the Math.log, and samples do not work properly. The samples should not rely on JDK internals, and should just use the custom written payload.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmh pull/60/head:pull/60
$ git checkout pull/60

Update a local copy of the PR:
$ git checkout pull/60
$ git pull https://git.openjdk.java.net/jmh pull/60/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 60

View PR using the GUI difftool:
$ git pr show -t 60

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmh/pull/60.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 9, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2022

Webrevs

@shipilev shipilev merged commit 301b9b6 into openjdk:master Feb 10, 2022
@shipilev shipilev deleted the 7903094-math-samples branch February 14, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
1 participant