CODETOOLS-7903094: JMH: Replace Math.log with predictable code in samples #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
Math.log
is no longer intrinsified into C2 IR, so dead code / constant fold examples no longer work. It seems to have started since JDK 9 and JDK-8152907 that now defers the computation ofMath.log
to quick LIBM stub. It does, however, limits the compiler optimizations around the Math.log, and samples do not work properly. The samples should not rely on JDK internals, and should just use the custom written payload.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmh pull/60/head:pull/60
$ git checkout pull/60
Update a local copy of the PR:
$ git checkout pull/60
$ git pull https://git.openjdk.java.net/jmh pull/60/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 60
View PR using the GUI difftool:
$ git pr show -t 60
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmh/pull/60.diff