7903118: Sanity Tests - Adding four JavaTest GUI newly automated sanity test scripts #24

gollayadav · 2022-03-07T16:16:52Z

Adding below automated JavaTest GUI Sanity Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.

1.Test_Config_Edit3.java
2.Test_Config_Load1.java
3.Test_Config_New1.java
4. Test_Config_Save2.java

Progress

Change must not contain extraneous whitespace

Issue

CODETOOLS-7903118: Sanity Tests - Adding four JavaTest GUI newly automated sanity test scripts

Reviewers

Dmitry Bessonov (@dbessono - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jtharness pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.java.net/jtharness pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jtharness/pull/24.diff

…ty test scripts

bridgekeeper · 2022-03-07T16:17:47Z

👋 Welcome back gollayadav! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-03-07T16:18:57Z

@gollayadav This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903118: Sanity Tests - Adding four JavaTest GUI newly automated sanity test scripts

Reviewed-by: dbessono

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dbessono) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlbridge · 2022-03-07T16:22:38Z

Webrevs

dbessono · 2022-03-11T01:18:53Z

gui-tests/src/gui/src/jthtest/Config_SaveEdit/Config_SaveEdit.java

+
+import jthtest.ConfigTools;
+
+public class Config_SaveEdit extends ConfigTools {


What is the purpose of this class ?

Thanks for checking. I think the class 'Config_SaveEdit' is not required because I have extended 'ConfigTools' from the main test script and I have removed it.

thanks, looks good

dbessono · 2022-03-11T01:24:26Z

gui-tests/src/gui/src/jthtest/Sanity_Tests/Test_Config_Edit3.java

+     *                                   at compile-time, but does not exist at
+     *                                   runtime.
+     */
+    @SuppressWarnings("deprecation")


Is this done to suppress the warning about deprecated "createWorkDirInTemp" ? "createWorkDirInTemp" is used widely and it seems only in this pack of tests its usage is accompanied with '@SuppressWarnings("deprecation")'. Why is it deprecated? Should it be kept deprecated?

Or possibly some other - non-deprecated method should be used instead of using a deprecated one and adding "@SuppressWarnings("deprecation")" ?

Thanks for reviewing. I will try to use the non-deprecated method and let you know.

dbessono · 2022-03-11T01:35:34Z

gui-tests/src/gui/src/jthtest/Sanity_Tests/Test_Config_Edit3.java

+     * @throws ClassNotFoundException    If the class does not find it in the
+     *                                   classpath.
+     *
+     * @throws InvocationTargetException Holds an exception thrown by an invoked
+     *                                   method or constructor.
+     *
+     * @throws NoSuchMethodException     Occurs when a method is called that exists
+     *                                   at compile-time, but does not exist at
+     *                                   runtime.


What is the idea of copying here a very general description of each exception? This comment seems applicable to all the tests in the PR.

Thanks for reviewing. I think this general description is not required for each exception and I have removed this for all the tests in PR.

…t-SanityTestCases

…wo files

dbessono

With the latest changes Test_Config_Load1.java and Test_Config_Save2.java look not compilable any more.

gollayadav · 2022-03-26T19:35:50Z

With the latest changes Test_Config_Load1.java and Test_Config_Save2.java look not compilable any more.

Sorry for the inconvenience caused. I have corrected the compilation errors now. Could you please check.

dbessono

Looks good, thanks

gollayadav · 2022-03-27T17:35:22Z

/integrate

openjdk · 2022-03-27T17:35:59Z

@gollayadav
Your change (at version bd44690) is now ready to be sponsored by a Committer.

dbessono · 2022-03-27T19:39:26Z

/sponsor

openjdk · 2022-03-27T19:40:38Z

Going to push as commit a800429.

openjdk · 2022-03-27T19:41:00Z

@dbessono @gollayadav Pushed as commit a800429.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

7903118: Sanity Tests - Adding four JavaTest GUI newly automated sani…

0e9f94e

…ty test scripts

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2022

dbessono reviewed Mar 11, 2022

View reviewed changes

golla.yadav@oracle.com added 2 commits March 24, 2022 13:04

Merge branch 'master' of github.com:gollayadav/jtharness into JavaTes…

43eb0e1

…t-SanityTestCases

7903118: Sanity Tests - Updated the scripts as per the review comments

c72fe78

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022

7903118: Sanity Tests - Corrected the whitespace/tabspace errors

c7102d6

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022

7903118: Sanity Tests - Updated the scripts as per the review comments

406351a

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022

7903118: Sanity Tests - Corrected the trailing whitespace errors in t…

df2094d

…wo files

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022

dbessono suggested changes Mar 25, 2022

View reviewed changes

7903118: Sanity Tests - Fixed the compilation errors

bd44690

dbessono self-requested a review March 27, 2022 12:54

dbessono approved these changes Mar 27, 2022

View reviewed changes

openjdk bot added the sponsor Pull request requires a sponsor label Mar 27, 2022

openjdk bot added the integrated Pull request has been integrated label Mar 27, 2022

openjdk bot closed this Mar 27, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request requires a sponsor labels Mar 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7903118: Sanity Tests - Adding four JavaTest GUI newly automated sanity test scripts #24

7903118: Sanity Tests - Adding four JavaTest GUI newly automated sanity test scripts #24

gollayadav commented Mar 7, 2022 •

edited by openjdk bot

bridgekeeper bot commented Mar 7, 2022

openjdk bot commented Mar 7, 2022 •

edited

mlbridge bot commented Mar 7, 2022 •

edited

dbessono Mar 11, 2022

gollayadav Mar 24, 2022 •

edited

dbessono Mar 25, 2022

dbessono Mar 11, 2022

dbessono Mar 11, 2022 •

edited

gollayadav Mar 24, 2022

dbessono Mar 11, 2022 •

edited

gollayadav Mar 24, 2022 •

edited

dbessono left a comment

gollayadav commented Mar 26, 2022

dbessono left a comment

gollayadav commented Mar 27, 2022

openjdk bot commented Mar 27, 2022

dbessono commented Mar 27, 2022

openjdk bot commented Mar 27, 2022

openjdk bot commented Mar 27, 2022


		import jthtest.ConfigTools;

		public class Config_SaveEdit extends ConfigTools {

7903118: Sanity Tests - Adding four JavaTest GUI newly automated sanity test scripts #24

7903118: Sanity Tests - Adding four JavaTest GUI newly automated sanity test scripts #24

Conversation

gollayadav commented Mar 7, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 7, 2022

openjdk bot commented Mar 7, 2022 • edited

mlbridge bot commented Mar 7, 2022 • edited

Webrevs

dbessono Mar 11, 2022

Choose a reason for hiding this comment

gollayadav Mar 24, 2022 • edited

Choose a reason for hiding this comment

dbessono Mar 25, 2022

Choose a reason for hiding this comment

dbessono Mar 11, 2022

Choose a reason for hiding this comment

dbessono Mar 11, 2022 • edited

Choose a reason for hiding this comment

gollayadav Mar 24, 2022

Choose a reason for hiding this comment

dbessono Mar 11, 2022 • edited

Choose a reason for hiding this comment

gollayadav Mar 24, 2022 • edited

Choose a reason for hiding this comment

dbessono left a comment

Choose a reason for hiding this comment

gollayadav commented Mar 26, 2022

dbessono left a comment

Choose a reason for hiding this comment

gollayadav commented Mar 27, 2022

openjdk bot commented Mar 27, 2022

dbessono commented Mar 27, 2022

openjdk bot commented Mar 27, 2022

openjdk bot commented Mar 27, 2022

gollayadav commented Mar 7, 2022 •

edited by openjdk bot

openjdk bot commented Mar 7, 2022 •

edited

mlbridge bot commented Mar 7, 2022 •

edited

gollayadav Mar 24, 2022 •

edited

dbessono Mar 11, 2022 •

edited

dbessono Mar 11, 2022 •

edited

gollayadav Mar 24, 2022 •

edited