Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903177: Feature Tests - Adding five JavaTest GUI legacy automated test scripts #29

Closed
wants to merge 6 commits into from

Conversation

gollayadav
Copy link
Contributor

@gollayadav gollayadav commented May 3, 2022

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.

1.Config_Load5.java
2.Config_Load6.java
3.Config_LoadEdit1.java
4.Config_LoadEdit2.java
5.Config_LoadEdit3.java


Progress

  • Change must not contain extraneous whitespace

Issue

  • CODETOOLS-7903177: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jtharness pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.java.net/jtharness pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jtharness/pull/29.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 3, 2022

👋 Welcome back gollayadav! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 3, 2022

@gollayadav This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903177: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Reviewed-by: dbessono

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 036dae1: 7903170: Sanity Tests - Adding JavaTest GUI newly automated test scripts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dbessono) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 3, 2022
@gollayadav gollayadav changed the title 7903177: Feature Tests - Adding five JavaTest GUI legacy automated feature test scripts 7903177: Feature Tests - Adding five JavaTest GUI legacy automated test scripts May 3, 2022
@mlbridge
Copy link

mlbridge bot commented May 3, 2022

Webrevs

Comment on lines 32 to 35
/**
*
* @author linfar
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks not correct. Instead it would be better to have a short description of what the test is doing.

Comment on lines 44 to 48
* @throws ClassNotFoundException
*
* @throws InvocationTargetException
*
* @throws NoSuchMethodException
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks not correct, could be removed

Comment on lines 46 to 50
* @throws ClassNotFoundException
*
* @throws InvocationTargetException
*
* @throws NoSuchMethodException
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks not correct

Comment on lines 47 to 51
* @throws ClassNotFoundException
*
* @throws InvocationTargetException
*
* @throws NoSuchMethodException
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

Updated/Modified the Config_LoadEdit1.java as per the review comments
Updated/Modified the Config_LoadEdit2.java as per review comments
Updated/Modified the Config_LoadEdit3.java as per review comments
@gollayadav
Copy link
Contributor Author

Thank You for your time in reviewing. I have updated/modified the scripts as per the review comments. Could you please check.

Comment on lines 32 to 37
/**
*This tests verifies the load button under configuration editor
*/
public class Config_LoadEdit extends ConfigTools {

}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the first iteration missed that this test is empty. It it really needed at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this empty test script is not required and removing it.

Copy link
Collaborator

@dbessono dbessono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this test?

/**
 *This tests verifies the load button under configuration editor
 */
public class Config_LoadEdit extends ConfigTools {

}

Verified that Config_LoadEdit.java is not required and removed this empty test script.
Copy link
Collaborator

@dbessono dbessono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, looking good

@gollayadav
Copy link
Contributor Author

/integrate

@dbessono
Copy link
Collaborator

/sponsor

@openjdk openjdk bot added the sponsor Pull request requires a sponsor label May 20, 2022
@openjdk
Copy link

openjdk bot commented May 20, 2022

@gollayadav
Your change (at version 0634d25) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented May 20, 2022

Going to push as commit 4c0a9ad.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 036dae1: 7903170: Sanity Tests - Adding JavaTest GUI newly automated test scripts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 20, 2022
@openjdk openjdk bot closed this May 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 20, 2022
@openjdk openjdk bot removed the sponsor Pull request requires a sponsor label May 20, 2022
@openjdk
Copy link

openjdk bot commented May 20, 2022

@dbessono @gollayadav Pushed as commit 4c0a9ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants