New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903177: Feature Tests - Adding five JavaTest GUI legacy automated test scripts #29
Conversation
…ature test scripts
👋 Welcome back gollayadav! A progress list of the required criteria for merging this PR into |
@gollayadav This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dbessono) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
/** | ||
* | ||
* @author linfar | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks not correct. Instead it would be better to have a short description of what the test is doing.
* @throws ClassNotFoundException | ||
* | ||
* @throws InvocationTargetException | ||
* | ||
* @throws NoSuchMethodException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks not correct, could be removed
* @throws ClassNotFoundException | ||
* | ||
* @throws InvocationTargetException | ||
* | ||
* @throws NoSuchMethodException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks not correct
* @throws ClassNotFoundException | ||
* | ||
* @throws InvocationTargetException | ||
* | ||
* @throws NoSuchMethodException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
Updated/Modified the Config_LoadEdit1.java as per the review comments
Updated/Modified the Config_LoadEdit2.java as per review comments
Updated/Modified the Config_LoadEdit3.java as per review comments
Thank You for your time in reviewing. I have updated/modified the scripts as per the review comments. Could you please check. |
/** | ||
*This tests verifies the load button under configuration editor | ||
*/ | ||
public class Config_LoadEdit extends ConfigTools { | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the first iteration missed that this test is empty. It it really needed at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that this empty test script is not required and removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this test?
/**
*This tests verifies the load button under configuration editor
*/
public class Config_LoadEdit extends ConfigTools {
}
Verified that Config_LoadEdit.java is not required and removed this empty test script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates, looking good
/integrate |
/sponsor |
@gollayadav |
@dbessono @gollayadav Pushed as commit 4c0a9ad. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
1.Config_Load5.java
2.Config_Load6.java
3.Config_LoadEdit1.java
4.Config_LoadEdit2.java
5.Config_LoadEdit3.java
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jtharness pull/29/head:pull/29
$ git checkout pull/29
Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.java.net/jtharness pull/29/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29
View PR using the GUI difftool:
$ git pr show -t 29
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jtharness/pull/29.diff