Skip to content
This repository has been archived by the owner. It is now read-only.

8261399: Cleanup code based on code review comments #176

Closed
wants to merge 1 commit into from

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Feb 9, 2021

Cleanup based on review comments in openjdk/jdk#2403

This PR handles :
Removing incorrect maxNativeTextureSize comment : openjdk/jdk#2403 (comment)
Removes import in CGraphicsConfig.java : openjdk/jdk#2403 (comment)
Removes OpenGL comments in MTLContext : openjdk/jdk#2403 (comment) , openjdk/jdk#2403 (comment)


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8261399: Cleanup code based on code review comments

Download

$ git fetch https://git.openjdk.java.net/lanai pull/176/head:pull/176
$ git checkout pull/176

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 9, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261399: Cleanup code based on code review comments

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 9, 2021

Webrevs

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Feb 9, 2021

/integrate

@openjdk openjdk bot closed this Feb 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2021

@jayathirthrao Pushed as commit 131a603.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8261399 branch Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant