Skip to content
This repository has been archived by the owner. It is now read-only.

8252706: Enable usage of rowBytesOffset for LCD non cache rendering #87

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Sep 2, 2020

In LCD non-cache rendering we are passing rowBytesOffset but we are not using it.Replicate OGL behaviour for use cases where we will have some value in rowBytesOffset.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252706: Enable usage of rowBytesOffset for LCD non cache rendering

Download

$ git fetch https://git.openjdk.java.net/lanai pull/87/head:pull/87
$ git checkout pull/87

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2020

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2020

@jayathirthrao This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252706: Enable usage of rowBytesOffset for LCD non cache rendering
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate bcc85aa76edab20430c3d28b56647c365696c69a.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 2, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2020

Webrevs

@jayathirthrao
Copy link
Member Author

jayathirthrao commented Sep 2, 2020

/integrate

@openjdk openjdk bot closed this Sep 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 2, 2020
@openjdk
Copy link

openjdk bot commented Sep 2, 2020

@jayathirthrao
Pushed as commit d3bbb05.

@jayathirthrao jayathirthrao deleted the JDK-8252706 branch Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
1 participant