Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265691: Some Object constructor methods aren't ES6 compliant #14

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

szegedi
Copy link
Collaborator

@szegedi szegedi commented Apr 21, 2021

Object constructor methods freeze, isFrozen, seal, isSealed, preventExtensions, isExtensible, getOwnPropertyNames, getOwnPropertySymbols operate under ES5 semantics even under ES6 language when their argument is not an object.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8265691: Some Object constructor methods aren't ES6 compliant

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/nashorn pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.java.net/nashorn pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/nashorn/pull/14.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2021

👋 Welcome back attila! A progress list of the required criteria for merging this PR into main will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 21, 2021
@szegedi szegedi merged commit b5e29d4 into openjdk:main Apr 23, 2021
@szegedi szegedi deleted the es6-fixes branch April 23, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant