Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8244244: Better representing typedef in jextract API #137

Closed
wants to merge 3 commits into from
Closed

8244244: Better representing typedef in jextract API #137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5030a4
Represent typedef with Declaration.Variable instead of Declaration.Sc…
slowhog Apr 29, 2020
2fa5f91
Add Declaration.Typedef
slowhog May 1, 2020
a8c6075
Cleanup of unintended residuals
slowhog May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/jdk.incubator.jextract/share/classes/jdk/incubator/jextract/Declaration.java
View file
Open in desktop
Expand Up @@ -227,11 +227,7 @@ enum Kind {
/**
* Function parameter declaration.
*/
PARAMETER,
/**
* Type definition declaration.
*/
TYPE;
PARAMETER;
}

/**
Expand Down
6 changes: 1 addition & 5 deletions src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/DeclarationImpl.java
View file
Open in desktop
Expand Up @@ -200,11 +200,7 @@ public boolean equals(Object o) {
if (!(o instanceof Declaration.Variable)) return false;

Declaration.Variable variable = (Declaration.Variable) o;
if (variable.kind() == Kind.TYPE) {
if (!variable.name().equals(name())) return false;
} else {
if (!super.equals(o)) return false;
}
if (!super.equals(o)) return false;
return kind == variable.kind() &&
type.equals(variable.type());
}
Expand Down
185 changes: 0 additions & 185 deletions test/jdk/java/jextract/TestAnonymousDecl.java
View file
Open in desktop

This file was deleted.

90 changes: 0 additions & 90 deletions test/jdk/java/jextract/anonymousDecl.h
View file
Open in desktop

This file was deleted.