Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261073: Remove @C annotations from jextracted code #447

Closed

Conversation

sundararajana
Copy link
Member

@sundararajana sundararajana commented Feb 4, 2021

removing C type annotations in generated code


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8261073: Remove @C annotations from jextracted code

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/447/head:pull/447
$ git checkout pull/447

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 4, 2021

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 4, 2021
Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good - to be clear, the goal here is to replace type annotations with some javadoc content which will point at the C signature of a function.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261073: Remove @C annotations from jextracted code

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the foreign-jextract branch:

  • 4d083c1: 8240373: Jextract assigns type "Void" to enum macros

Please see this link for an up-to-date comparison between the source branch of this pull request and the foreign-jextract branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 4, 2021
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented Feb 4, 2021

/integrate

@openjdk openjdk bot closed this Feb 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@sundararajana Since your change was applied there has been 1 commit pushed to the foreign-jextract branch:

  • 4d083c1: 8240373: Jextract assigns type "Void" to enum macros

Your commit was automatically rebased without conflicts.

Pushed as commit cb45274.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 4, 2021

Webrevs

@sundararajana sundararajana deleted the JDK-8261073 branch Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants