Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8267989: Exceptions thrown during upcalls should be handled #543

Closed
wants to merge 8 commits into from
Closed

8267989: Exceptions thrown during upcalls should be handled #543

wants to merge 8 commits into from

Commits on May 31, 2021

  1. Handle exception uniformly across upcall modes

    @JornVernee
    JornVernee committed May 31, 2021
    Copy the full SHA
    460e66b View commit details
    Browse the repository at this point in the history

  2. Add tests

    @JornVernee
    JornVernee committed May 31, 2021
    Copy the full SHA
    5595a98 View commit details
    Browse the repository at this point in the history

  3. Fix test and add documentation + ERR_UNCAUGHT_EXCEPTION

    @JornVernee
    JornVernee committed May 31, 2021
    Copy the full SHA
    aeb4b08 View commit details
    Browse the repository at this point in the history

  4. Use priviledgedGetProperty instead of Integer.getInteger

    @JornVernee
    JornVernee committed May 31, 2021
    Copy the full SHA
    b25b8a9 View commit details
    Browse the repository at this point in the history

  5. Address review comments: 

    - tweak documentation
- remove system property
- simplify test & check stderr for stack trace message
    @JornVernee
    JornVernee committed May 31, 2021
    Copy the full SHA
    668e15d View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. - remove exit code constant 

    - add security manager into test
- use privilegedGetProperty instead of System.getProperty in CABI
    @JornVernee
    JornVernee committed Jun 1, 2021
    Copy the full SHA
    a7e73a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Eagerly check whether upcall target throws any exceptions. 

    Adapt the existing exception check done by MemoryHandles to be more lenient towards bound method handles which might or might not throw an exception, and re-use that check.
    @JornVernee
    JornVernee committed Jun 2, 2021
    Copy the full SHA
    2a602b0 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @JornVernee
    JornVernee committed Jun 2, 2021
    Copy the full SHA
    9bb8c1a View commit details
    Browse the repository at this point in the history