-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295290: Add Windows ARM64 ABI support to the Foreign Function & Memory API #754
Closed
swesonga
wants to merge
12
commits into
openjdk:foreign-memaccess+abi
from
swesonga:WindowsAArch64ABI
Closed
8295290: Add Windows ARM64 ABI support to the Foreign Function & Memory API #754
swesonga
wants to merge
12
commits into
openjdk:foreign-memaccess+abi
from
swesonga:WindowsAArch64ABI
Commits on Nov 22, 2022
-
Add Windows ARM64 ABI support to the Foreign Function & Memory API
There are 2 primary differences between the Windows ARM64 ABI and the macOS/Linux ARM64 ABI: variadic floating point arguments are passed in general purpose registers on Windows (instead of the vector registers). In addition to this, up to 64 bytes of a struct being passed to a variadic function can be placed in general purpose registers. This happens regardless of the type of struct (HFA or other generic struct). This means that a struct can be split across registers and the stack when invoking a variadic function. This change introduces tests that compute the sum of the fields of structs containing 1-4 ints, floats, and doubles to verify that each field is correctly assigned a register or stack location when invoking a variadic function (both when the struct can be passed entirely in registers as well as when the struct spills onto the stack). For details about the Foreign Function & Memory API, see JEP 434 defined at https://openjdk.org/jeps/434 The Windows ARM64 ABI conventions are documented at https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions
Configuration menu - View commit details
-
Copy full SHA for 7139289 - Browse repository at this point
Copy the full SHA 7139289View commit details
Commits on Dec 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1c12be8 - Browse repository at this point
Copy the full SHA 1c12be8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3580e12 - Browse repository at this point
Copy the full SHA 3580e12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52da2e8 - Browse repository at this point
Copy the full SHA 52da2e8View commit details
Commits on Dec 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d882168 - Browse repository at this point
Copy the full SHA d882168View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d2f4e2 - Browse repository at this point
Copy the full SHA 3d2f4e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 385295d - Browse repository at this point
Copy the full SHA 385295dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08fdbf2 - Browse repository at this point
Copy the full SHA 08fdbf2View commit details
Commits on Dec 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cd0ccdd - Browse repository at this point
Copy the full SHA cd0ccddView commit details
Commits on Jan 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 121ddc6 - Browse repository at this point
Copy the full SHA 121ddc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9ccd3b - Browse repository at this point
Copy the full SHA b9ccd3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccae2d8 - Browse repository at this point
Copy the full SHA ccae2d8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.