8313894: Rename isTrivial linker option to critical

[JornVernee]

The name isTrivial isn't ideal.

The 'is' can be dropped, and we'd like to switch to the name 'critical' which leans on an established meaning (JNI GetPrimitiveArrayCritical, java criticals).

All in all, the goal of the name is to avoid making too many promises about what this option does (although that is covered by the javadoc). It is intended to act more as a hint to the runtime. For instance, on x64 it will elide the thread state transition done by a native call, but this is not the case on all implementations (e.g. the fallback linker).

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8313894: Rename isTrivial linker option to critical (Enhancement - P4)

Reviewers

• Per Minborg (@minborg - Committer)
• Maurizio Cimadamore (@mcimadamore - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-foreign.git pull/859/head:pull/859
$ git checkout pull/859

Update a local copy of the PR:
$ git checkout pull/859
$ git pull https://git.openjdk.org/panama-foreign.git pull/859/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 859

View PR using the GUI difftool:
$ git pr show -t 859

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-foreign/pull/859.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (b37167bc)

[minborg]

LGTM. I think the new name is an improvement.

[openjdk]

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313894: Rename isTrivial linker option to critical

Reviewed-by: pminborg, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the foreign-memaccess+abi branch:

• 29e621e: Fix test with strcat

Please see this link for an up-to-date comparison between the source branch of this pull request and the foreign-memaccess+abi branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

[mcimadamore]

Looks good!

[JornVernee]

/integrate

[openjdk]

Going to push as commit ea82d41.
Since your change was applied there has been 1 commit pushed to the foreign-memaccess+abi branch:

• 29e621e: Fix test with strcat

Your commit was automatically rebased without conflicts.

[openjdk]

@JornVernee Pushed as commit ea82d41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.