Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318678: Vector access on heap MemorySegments only works for byte[] #218

Closed
wants to merge 1 commit into from

Conversation

minborg
Copy link
Collaborator

@minborg minborg commented Oct 25, 2023

This PR proposes to allow Vector access to any heap MemorySegment provided alignment restrictions are respected.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318678: Vector access on heap MemorySegments only works for byte[] (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-vector.git pull/218/head:pull/218
$ git checkout pull/218

Update a local copy of the PR:
$ git checkout pull/218
$ git pull https://git.openjdk.org/panama-vector.git pull/218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 218

View PR using the GUI difftool:
$ git pr show -t 218

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-vector/pull/218.diff

Webrev

Link to Webrev Comment

@minborg
Copy link
Collaborator Author

minborg commented Oct 25, 2023

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2023

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@minborg This repository has not been configured to use the csr command.

@mlbridge
Copy link

mlbridge bot commented Oct 25, 2023

Webrevs

@mcimadamore
Copy link
Collaborator

This should go in mainline. Please close this PR.

@minborg minborg closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants