-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296916: RISC-V: Move some small macro-assembler functions to header file #50
Conversation
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This change should be low risk and will help minimize difference with jdk mainline.
@DingliZhang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thanks for the review! |
@DingliZhang |
/sponsor |
Going to push as commit 9b88e8e.
Your commit was automatically rebased without conflicts. |
@RealFYang @DingliZhang Pushed as commit 9b88e8e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this backport to riscv-port-jdk17u.
Backport of JDK-8296916.
The original patch cannot be directly applied because jdk17u has no JDK-8294100 with
MacroAssembler::object_move
and has novneg_v
, either.Testing:
Tier1-3 passed without new failure on unmacthed (release).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/50/head:pull/50
$ git checkout pull/50
Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/50/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 50
View PR using the GUI difftool:
$ git pr show -t 50
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/50.diff
Webrev
Link to Webrev Comment