Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296916: RISC-V: Move some small macro-assembler functions to header file #50

Closed

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented May 15, 2023

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8296916.
The original patch cannot be directly applied because jdk17u has no JDK-8294100 with MacroAssembler::object_move and has no vneg_v, either.

Testing:

Tier1-3 passed without new failure on unmacthed (release).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296916: RISC-V: Move some small macro-assembler functions to header file

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/50.diff

Webrev

Link to Webrev Comment

@DingliZhang DingliZhang changed the title 8296916: RISC-V: Move some small macro-assembler functions to header file Backport c3b285a8acaf4a6771e80b0a19bf21d6873f1a38 May 15, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c3b285a8acaf4a6771e80b0a19bf21d6873f1a38 8296916: RISC-V: Move some small macro-assembler functions to header file May 15, 2023
@openjdk
Copy link

openjdk bot commented May 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 15, 2023
@mlbridge
Copy link

mlbridge bot commented May 15, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This change should be low risk and will help minimize difference with jdk mainline.

@openjdk
Copy link

openjdk bot commented May 18, 2023

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296916: RISC-V: Move some small macro-assembler functions to header file

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the riscv-port branch:

  • 0bdef91: 8308089: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence
  • 3a02888: 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register

Please see this link for an up-to-date comparison between the source branch of this pull request and the riscv-port branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 18, 2023
@DingliZhang
Copy link
Member Author

Thanks for the review!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 18, 2023
@openjdk
Copy link

openjdk bot commented May 18, 2023

@DingliZhang
Your change (at version a5e79b1) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 18, 2023

Going to push as commit 9b88e8e.
Since your change was applied there have been 2 commits pushed to the riscv-port branch:

  • 0bdef91: 8308089: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence
  • 3a02888: 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 18, 2023
@openjdk openjdk bot closed this May 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 18, 2023
@openjdk
Copy link

openjdk bot commented May 18, 2023

@RealFYang @DingliZhang Pushed as commit 9b88e8e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants